| Index: tools/telemetry/telemetry/value/skip_unittest.py
|
| diff --git a/tools/telemetry/telemetry/value/failure_unittest.py b/tools/telemetry/telemetry/value/skip_unittest.py
|
| similarity index 63%
|
| copy from tools/telemetry/telemetry/value/failure_unittest.py
|
| copy to tools/telemetry/telemetry/value/skip_unittest.py
|
| index 799e047f691517c7f944ea34f8067fd8cf65b41f..beab6244aed9221a3bbcb24112e96aa081caf630 100644
|
| --- a/tools/telemetry/telemetry/value/failure_unittest.py
|
| +++ b/tools/telemetry/telemetry/value/skip_unittest.py
|
| @@ -3,12 +3,11 @@
|
| # found in the LICENSE file.
|
|
|
| import os
|
| -import sys
|
| import unittest
|
|
|
| from telemetry import value
|
| from telemetry.page import page_set
|
| -from telemetry.value import failure
|
| +from telemetry.value import skip
|
|
|
| class TestBase(unittest.TestCase):
|
| def setUp(self):
|
| @@ -20,17 +19,8 @@ class TestBase(unittest.TestCase):
|
| return self.page_set.pages
|
|
|
| class ValueTest(TestBase):
|
| - def testName(self):
|
| - v0 = failure.FailureValue.FromMessage(self.pages[0], 'Failure')
|
| - self.assertEqual('Exception', v0.name)
|
| - try:
|
| - raise NotImplementedError()
|
| - except Exception:
|
| - v1 = failure.FailureValue(self.pages[0], sys.exc_info())
|
| - self.assertEqual('NotImplementedError', v1.name)
|
| -
|
| def testBuildbotAndRepresentativeValue(self):
|
| - v = failure.FailureValue.FromMessage(self.pages[0], 'Failure')
|
| + v = skip.SkipValue(self.pages[0], 'page skipped for testing reason')
|
| self.assertIsNone(v.GetBuildbotValue())
|
| self.assertIsNone(v.GetBuildbotDataType(
|
| value.COMPUTED_PER_PAGE_SUMMARY_OUTPUT_CONTEXT))
|
| @@ -39,6 +29,6 @@ class ValueTest(TestBase):
|
| self.assertIsNone(v.GetRepresentativeString())
|
|
|
| def testAsDict(self):
|
| - v = failure.FailureValue.FromMessage(self.pages[0], 'Failure')
|
| + v = skip.SkipValue(self.pages[0], 'page skipped for testing reason')
|
| d = v.AsDictWithoutBaseClassEntries()
|
| - self.assertTrue(d['value'].find('Exception: Failure') > -1)
|
| + self.assertEquals(d['reason'], 'page skipped for testing reason')
|
|
|