chrome/android/java/res/layout/website_settings.xml - Issue 409003002: Redesign GUI of Website Setting Popup Dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/website_settings.xml

Issue 409003002: Redesign GUI of Website Setting Popup Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xhdpi/pageinfo_warning_minor.png ('k') | chrome/android/java/res/values/colors.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/website_settings.xml

diff --git a/chrome/android/java/res/layout/website_settings.xml b/chrome/android/java/res/layout/website_settings.xml

index 074844bb034620995a9c59d18b80124f950d69c9..8d5a247ddceaacd09b18ba9d23660da612014bde 100644

--- a/chrome/android/java/res/layout/website_settings.xml

+++ b/chrome/android/java/res/layout/website_settings.xml

@@ -7,24 +7,22 @@

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

aurimas (slooooooooow) 2014/07/23 01:17:40 Please format this xml file. It is not properly in

Ian Wen 2014/07/23 01:30:06 Done.

android:orientation="horizontal"

android:layout_width="match_parent"

- android:layout_height="match_parent"

- android:paddingTop="@dimen/certificate_viewer_padding"

- android:paddingBottom="@dimen/certificate_viewer_padding">

+ android:layout_height="match_parent" >

<ImageView android:id="@+id/website_settings_icon"

android:layout_width="wrap_content"

- android:layout_height="wrap_content"

- android:paddingStart="@dimen/certificate_viewer_padding"/>

- <LinearLayout android:orientation="vertical"

+ android:layout_height="wrap_content" />

+ <LinearLayout android:id="@+id/website_settings_text_layout"

+ android:orientation="vertical"

android:layout_width="wrap_content"

android:layout_height="wrap_content"

- android:paddingStart="@dimen/certificate_viewer_padding"

- android:paddingEnd="@dimen/certificate_viewer_padding">

+ android:paddingStart="@dimen/certificate_viewer_padding_thin">

<TextView android:id="@+id/website_settings_headline"

android:layout_width="wrap_content"

android:layout_height="wrap_content"

- android:textStyle="bold"/>

+ android:textStyle="bold"

+ android:paddingBottom="@dimen/certificate_viewer_padding_thin" />

<TextView android:id="@+id/website_settings_description"

android:layout_width="wrap_content"

- android:layout_height="wrap_content"/>

+ android:layout_height="wrap_content" />

</LinearLayout>