chrome/android/java/res/layout/website_settings.xml - Issue 409003002: Redesign GUI of Website Setting Popup Dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/website_settings.xml

Issue 409003002: Redesign GUI of Website Setting Popup Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xhdpi/pageinfo_warning_minor.png ('k') | chrome/android/java/res/values/colors.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright (c) 2013 The Chromium Authors. All rights reserved.	2 <!-- Copyright (c) 2013 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
	aurimas (slooooooooow) 2014/07/23 01:17:40 Please format this xml file. It is not properly in Please format this xml file. It is not properly indented. Ian Wen 2014/07/23 01:30:06 Done. Show quoted text On 2014/07/23 01:17:40, aurimas wrote: > Please format this xml file. It is not properly indented. Done.
8 android:orientation="horizontal"	8 android:orientation="horizontal"

9 android:layout_width="match_parent"	9 android:layout_width="match_parent"

10 android:layout_height="match_parent"	10 android:layout_height="match_parent" >

11 android:paddingTop="@dimen/certificate_viewer_padding"

12 android:paddingBottom="@dimen/certificate_viewer_padding">

13 <ImageView android:id="@+id/website_settings_icon"	11 <ImageView android:id="@+id/website_settings_icon"

14 android:layout_width="wrap_content"	12 android:layout_width="wrap_content"

15 android:layout_height="wrap_content"	13 android:layout_height="wrap_content" />

16 android:paddingStart="@dimen/certificate_viewer_padding"/>	14 <LinearLayout android:id="@+id/website_settings_text_layout"

17 <LinearLayout android:orientation="vertical"	15 android:orientation="vertical"

18 android:layout_width="wrap_content"	16 android:layout_width="wrap_content"

19 android:layout_height="wrap_content"	17 android:layout_height="wrap_content"

20 android:paddingStart="@dimen/certificate_viewer_padding"	18 android:paddingStart="@dimen/certificate_viewer_padding_thin">

21 android:paddingEnd="@dimen/certificate_viewer_padding">

22 <TextView android:id="@+id/website_settings_headline"	19 <TextView android:id="@+id/website_settings_headline"

23 android:layout_width="wrap_content"	20 android:layout_width="wrap_content"

24 android:layout_height="wrap_content"	21 android:layout_height="wrap_content"

25 android:textStyle="bold"/>	22 android:textStyle="bold"

	23 android:paddingBottom="@dimen/certificate_viewer_padding_thin" />

26 <TextView android:id="@+id/website_settings_description"	24 <TextView android:id="@+id/website_settings_description"

27 android:layout_width="wrap_content"	25 android:layout_width="wrap_content"

28 android:layout_height="wrap_content"/>	26 android:layout_height="wrap_content" />

29 </LinearLayout>	27 </LinearLayout>

30 </LinearLayout>	28 </LinearLayout>

OLD	NEW