Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(63)

Issue 408993002: Have media content and chrome browser tests load data from media/test/data (Closed)

Created:
4 years, 11 months ago by shadi
Modified:
4 years, 11 months ago
Reviewers:
asanka, xhwang
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, posciak+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jam, mcasas+watch_chromium.org, dominich, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, darin-cc_chromium.org, kmadhusu+watch_chromium.org, wjia+watch_chromium.org, Jered
Project:
chromium
Visibility:
Public.

Description

Have media content and chrome browser tests load data from media/test/data Update remaining encrypted media browser tests to use new player app. This is similar to r282795 + fix to GN builds. The fix is in media/BUILD.gn file. BUG=379314 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -2244 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 14 chunks +31 lines, -28 lines 0 comments Download
M chrome/browser/media/encrypted_media_istypesupported_browsertest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/media/media_browsertest.h View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/media/media_browsertest.cc View 3 chunks +17 lines, -30 lines 0 comments Download
D chrome/test/data/media/eme_player.html View 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/test/data/media/eme_player_js/app_loader.js View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/test/data/media/eme_player_js/clearkey_player.js View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/data/media/eme_player_js/eme_app.js View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/test/data/media/eme_player_js/file_io_test_player.js View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/test/data/media/eme_player_js/fps_observer.js View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/test/data/media/eme_player_js/globals.js View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/test/data/media/eme_player_js/media_source_utils.js View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/test/data/media/eme_player_js/player_utils.js View 1 chunk +0 lines, -186 lines 0 comments Download
D chrome/test/data/media/eme_player_js/prefixed_clearkey_player.js View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/data/media/eme_player_js/prefixed_widevine_player.js View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/test/data/media/eme_player_js/test_config.js View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/media/eme_player_js/utils.js View 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/test/data/media/eme_player_js/widevine_player.js View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/test/data/media/encrypted_frame_size_change.html View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/test/data/media/frame_size_change-av-enc-v.webm View Binary file 0 comments Download
D chrome/test/data/media/mse_config_change.html View 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/test/data/media/test_key_system_instantiation.html View 1 chunk +0 lines, -21 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 7 chunks +40 lines, -31 lines 0 comments Download
M content/browser/media/media_browsertest.h View 3 chunks +9 lines, -10 lines 0 comments Download
M content/browser/media/media_browsertest.cc View 7 chunks +43 lines, -46 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 2 chunks +11 lines, -7 lines 0 comments Download
D content/test/data/media/blackwhite.html View 1 chunk +0 lines, -231 lines 0 comments Download
D content/test/data/media/encrypted_frame_size_change.html View 1 chunk +0 lines, -50 lines 0 comments Download
D content/test/data/media/encrypted_media_player.html View 1 chunk +0 lines, -37 lines 0 comments Download
D content/test/data/media/encrypted_media_utils.js View 1 chunk +0 lines, -142 lines 0 comments Download
D content/test/data/media/media_source_player.html View 1 chunk +0 lines, -35 lines 0 comments Download
D content/test/data/media/media_source_utils.js View 1 chunk +0 lines, -67 lines 0 comments Download
D content/test/data/media/media_utils.js View 1 chunk +0 lines, -50 lines 0 comments Download
D content/test/data/media/mse_config_change.html View 1 chunk +0 lines, -132 lines 0 comments Download
D content/test/data/media/player.html View 1 chunk +0 lines, -77 lines 0 comments Download
M media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/test_data_util.h View 1 chunk +15 lines, -0 lines 0 comments Download
M media/base/test_data_util.cc View 1 chunk +28 lines, -4 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + media/test/data/blackwhite.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/app_loader.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/clearkey_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/eme_app.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/file_io_test_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/fps_observer.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/globals.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/media_source_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/player_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/prefixed_clearkey_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/prefixed_widevine_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/test/data/eme_player_js/test_config.js View 1 chunk +65 lines, -0 lines 0 comments Download
A + media/test/data/eme_player_js/utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/widevine_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/encrypted_frame_size_change.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/media_source_player.html View 2 chunks +9 lines, -6 lines 0 comments Download
A + media/test/data/mse_config_change.html View 2 chunks +2 lines, -3 lines 0 comments Download
A + media/test/data/player.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/test_key_system_instantiation.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
shadi
Hi guys, I need your LGTM again. The last CL (https://codereview.chromium.org/398823004) got reverted because it ...
4 years, 11 months ago (2014-07-21 23:08:47 UTC) #1
xhwang
Good luck this time! pro-tip: You could upload the original CL first, then upload the ...
4 years, 11 months ago (2014-07-21 23:13:23 UTC) #2
asanka
Rubberstamp lgtm
4 years, 11 months ago (2014-07-22 16:34:38 UTC) #3
shadi
The CQ bit was checked by shadi@chromium.org
4 years, 11 months ago (2014-07-22 17:21:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/408993002/1
4 years, 11 months ago (2014-07-22 17:22:52 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
4 years, 11 months ago (2014-07-22 21:15:20 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 11 months ago (2014-07-22 22:05:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31012)
4 years, 11 months ago (2014-07-22 22:05:28 UTC) #8
shadi
The CQ bit was checked by shadi@chromium.org
4 years, 11 months ago (2014-07-22 22:37:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/408993002/1
4 years, 11 months ago (2014-07-22 22:39:27 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2014-07-22 23:33:22 UTC) #11
Message was sent while issue was closed.
Change committed as 284803

Powered by Google App Engine
This is Rietveld 408576698