Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 398823004: Have media content and chrome browser tests load data from media/test/data (Closed)

Created:
6 years, 5 months ago by shadi
Modified:
6 years, 5 months ago
Reviewers:
asanka, xhwang
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, posciak+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jam, mcasas+watch_chromium.org, dominich, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, darin-cc_chromium.org, kmadhusu+watch_chromium.org, wjia+watch_chromium.org, Jered
Project:
chromium
Visibility:
Public.

Description

Have media content and chrome browser tests load data from media/test/data Update remaining encrypted media browser tests to use new player app. (This is identical to r282795 which got reverted, i.e. revert of revert). The fix was submitted separately in r283757 BUG=379314 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -2244 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 14 chunks +31 lines, -28 lines 0 comments Download
M chrome/browser/media/encrypted_media_istypesupported_browsertest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/media/media_browsertest.h View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/media/media_browsertest.cc View 3 chunks +17 lines, -30 lines 0 comments Download
D chrome/test/data/media/eme_player.html View 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/test/data/media/eme_player_js/app_loader.js View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/test/data/media/eme_player_js/clearkey_player.js View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/data/media/eme_player_js/eme_app.js View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/test/data/media/eme_player_js/file_io_test_player.js View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/test/data/media/eme_player_js/fps_observer.js View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/test/data/media/eme_player_js/globals.js View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/test/data/media/eme_player_js/media_source_utils.js View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/test/data/media/eme_player_js/player_utils.js View 1 chunk +0 lines, -186 lines 0 comments Download
D chrome/test/data/media/eme_player_js/prefixed_clearkey_player.js View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/data/media/eme_player_js/prefixed_widevine_player.js View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/test/data/media/eme_player_js/test_config.js View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/media/eme_player_js/utils.js View 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/test/data/media/eme_player_js/widevine_player.js View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/test/data/media/encrypted_frame_size_change.html View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/test/data/media/frame_size_change-av-enc-v.webm View Binary file 0 comments Download
D chrome/test/data/media/mse_config_change.html View 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/test/data/media/test_key_system_instantiation.html View 1 chunk +0 lines, -21 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 7 chunks +40 lines, -31 lines 0 comments Download
M content/browser/media/media_browsertest.h View 3 chunks +9 lines, -10 lines 0 comments Download
M content/browser/media/media_browsertest.cc View 7 chunks +43 lines, -46 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 2 chunks +11 lines, -7 lines 0 comments Download
D content/test/data/media/blackwhite.html View 1 chunk +0 lines, -231 lines 0 comments Download
D content/test/data/media/encrypted_frame_size_change.html View 1 chunk +0 lines, -50 lines 0 comments Download
D content/test/data/media/encrypted_media_player.html View 1 chunk +0 lines, -37 lines 0 comments Download
D content/test/data/media/encrypted_media_utils.js View 1 chunk +0 lines, -142 lines 0 comments Download
D content/test/data/media/media_source_player.html View 1 chunk +0 lines, -35 lines 0 comments Download
D content/test/data/media/media_source_utils.js View 1 chunk +0 lines, -67 lines 0 comments Download
D content/test/data/media/media_utils.js View 1 chunk +0 lines, -50 lines 0 comments Download
D content/test/data/media/mse_config_change.html View 1 chunk +0 lines, -132 lines 0 comments Download
D content/test/data/media/player.html View 1 chunk +0 lines, -77 lines 0 comments Download
M media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/test_data_util.h View 1 chunk +15 lines, -0 lines 0 comments Download
M media/base/test_data_util.cc View 1 chunk +28 lines, -4 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + media/test/data/blackwhite.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/app_loader.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/clearkey_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/eme_app.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/file_io_test_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/fps_observer.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/globals.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/media_source_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/player_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/prefixed_clearkey_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/prefixed_widevine_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/test/data/eme_player_js/test_config.js View 1 chunk +65 lines, -0 lines 0 comments Download
A + media/test/data/eme_player_js/utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/eme_player_js/widevine_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/encrypted_frame_size_change.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/media_source_player.html View 2 chunks +9 lines, -6 lines 0 comments Download
A + media/test/data/mse_config_change.html View 2 chunks +2 lines, -3 lines 0 comments Download
A + media/test/data/player.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/test/data/test_key_system_instantiation.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
shadi
PTAL. This is exactly same CL as https://codereview.chromium.org/357413002 which got reverted due to missing files ...
6 years, 5 months ago (2014-07-19 00:21:02 UTC) #1
asanka
lgtm
6 years, 5 months ago (2014-07-20 04:56:45 UTC) #2
xhwang
lgtm
6 years, 5 months ago (2014-07-21 16:42:17 UTC) #3
shadi
The CQ bit was checked by shadi@chromium.org
6 years, 5 months ago (2014-07-21 16:54:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/398823004/1
6 years, 5 months ago (2014-07-21 16:55:12 UTC) #5
commit-bot: I haz the power
Change committed as 284489
6 years, 5 months ago (2014-07-21 19:57:10 UTC) #6
sky
6 years, 5 months ago (2014-07-21 20:16:47 UTC) #7
Message was sent while issue was closed.
On 2014/07/21 19:57:10, I haz the power (commit-bot) wrote:
> Change committed as 284489

Reverting as this broke linux gn bot:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/bu...

Powered by Google App Engine
This is Rietveld 408576698