Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 408893002: Cleanup WebViewGuest::CanEmbedderAccessGuestView and AppViewGuest::CanEmbedderAccessGuestView (Closed)

Created:
6 years, 5 months ago by Fady Samuel
Modified:
6 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_unnecessary_profile_usage
Project:
chromium
Visibility:
Public.

Description

Cleanup WebViewGuest::CanEmbedderAccessGuestView and AppViewGuest::CanEmbedderAccessGuestView TBR=fsamuel@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/browser/guest_view/app_view/app_view_guest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 5 months ago (2014-07-22 11:00:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/408893002/1
6 years, 5 months ago (2014-07-22 11:02:08 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 11:02:08 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-22 11:02:09 UTC) #4
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 5 months ago (2014-07-22 11:09:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/408893002/1
6 years, 5 months ago (2014-07-22 11:10:40 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 12:56:53 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 16:04:48 UTC) #8
Message was sent while issue was closed. 
Change committed as 284690

Powered by Google App Engine
This is Rietveld 408576698