Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 408893002: Cleanup WebViewGuest::CanEmbedderAccessGuestView and AppViewGuest::CanEmbedderAccessGuestView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unnecessary_profile_usage
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guest_view/app_view/app_view_guest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/web_view/web_view_guest.cc
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.cc b/chrome/browser/guest_view/web_view/web_view_guest.cc
index e6852d29fce3b0aa4b24fd72942b20ca89263643..5fa8f47480b07234f17e451de19c57045b8af3a1 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.cc
+++ b/chrome/browser/guest_view/web_view/web_view_guest.cc
@@ -11,7 +11,6 @@
#include "chrome/browser/extensions/api/web_request/web_request_api.h"
#include "chrome/browser/extensions/api/web_view/web_view_internal_api.h"
#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
-#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/menu_manager.h"
#include "chrome/browser/extensions/script_executor.h"
#include "chrome/browser/favicon/favicon_tab_helper.h"
@@ -49,6 +48,7 @@
#include "content/public/common/result_codes.h"
#include "content/public/common/stop_find_action.h"
#include "content/public/common/url_constants.h"
+#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/common/constants.h"
#include "extensions/common/permissions/permissions_data.h"
@@ -233,14 +233,13 @@ scoped_ptr<base::ListValue> WebViewGuest::MenuModelToValue(
bool WebViewGuest::CanEmbedderUseGuestView(
const std::string& embedder_extension_id) {
- Profile* profile = Profile::FromBrowserContext(browser_context());
- ExtensionService* service =
- extensions::ExtensionSystem::Get(profile)->extension_service();
const extensions::Extension* embedder_extension =
- service->GetExtensionById(embedder_extension_id, false);
- const extensions::PermissionsData* permissions_data =
- embedder_extension->permissions_data();
- return permissions_data->HasAPIPermission(
+ extensions::ExtensionRegistry::Get(browser_context())
+ ->enabled_extensions()
+ .GetByID(embedder_extension_id);
+ if (!embedder_extension)
+ return false;
+ return embedder_extension->permissions_data()->HasAPIPermission(
extensions::APIPermission::kWebView);
}
« no previous file with comments | « chrome/browser/guest_view/app_view/app_view_guest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698