Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 408853005: Convert bindings targets in mojo/mojo_services.gypi to GN. (Closed)

Created:
6 years, 5 months ago by yzshen1
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Convert bindings targets in mojo/mojo_services.gypi to GN. BUG=369643 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284533

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -22 lines) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 12 chunks +15 lines, -1 line 0 comments Download
A mojo/services/BUILD.gn View 1 1 chunk +20 lines, -0 lines 0 comments Download
A + mojo/services/dbus_echo/BUILD.gn View 1 1 chunk +3 lines, -2 lines 0 comments Download
A mojo/services/gles2/BUILD.gn View 1 1 chunk +27 lines, -0 lines 0 comments Download
A + mojo/services/public/interfaces/geometry/BUILD.gn View 1 1 chunk +3 lines, -2 lines 0 comments Download
A + mojo/services/public/interfaces/input_events/BUILD.gn View 1 1 chunk +7 lines, -2 lines 0 comments Download
A + mojo/services/public/interfaces/launcher/BUILD.gn View 1 1 chunk +7 lines, -3 lines 0 comments Download
A mojo/services/public/interfaces/native_viewport/BUILD.gn View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + mojo/services/public/interfaces/navigation/BUILD.gn View 1 1 chunk +7 lines, -3 lines 0 comments Download
A + mojo/services/public/interfaces/network/BUILD.gn View 1 1 chunk +5 lines, -3 lines 0 comments Download
A mojo/services/public/interfaces/surfaces/BUILD.gn View 1 1 chunk +19 lines, -0 lines 0 comments Download
A mojo/services/public/interfaces/view_manager/BUILD.gn View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + mojo/services/public/interfaces/window_manager/BUILD.gn View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/test_service/BUILD.gn View 1 1 chunk +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Issue 1257793004 Patch 1
Issue 1275613002 Patch 1
Issue 1275613002 Patch 20001

Messages

Total messages: 5 (0 generated)
yzshen1
Hi, Brett. Would you please take a look? Thanks!
6 years, 5 months ago (2014-07-21 18:03:19 UTC) #1
brettw
lgtm
6 years, 5 months ago (2014-07-21 20:19:33 UTC) #2
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 5 months ago (2014-07-21 20:26:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/408853005/20001
6 years, 5 months ago (2014-07-21 20:28:10 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 23:10:46 UTC) #5
Message was sent while issue was closed. 
Change committed as 284533

Powered by Google App Engine
This is Rietveld 408576698