Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1257793004: Support --build-dir commandline flag for {run,install}_mandoline.py (Closed)

Created:
5 years, 5 months ago by yzshen1
Modified:
5 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, yzshen+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support --build-dir commandline flag for {run,install}_mandoline.py BUG=None Committed: https://crrev.com/b9deae6d85d920cdd405b287ac44323060740fc0 Cr-Commit-Position: refs/heads/master@{#340364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M mandoline/tools/android/install_mandoline.py View 1 chunk +3 lines, -1 line 0 comments Download
M mandoline/tools/android/run_mandoline.py View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
5 years, 5 months ago (2015-07-24 22:17:18 UTC) #2
sky
LGTM
5 years, 5 months ago (2015-07-24 22:41:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257793004/1
5 years, 5 months ago (2015-07-24 22:46:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 22:55:01 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 22:56:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9deae6d85d920cdd405b287ac44323060740fc0
Cr-Commit-Position: refs/heads/master@{#340364}

Powered by Google App Engine
This is Rietveld 408576698