Chromium Code Reviews
Help | Chromium Project | Sign in
(19)

Issue 4088003: crash-reporter: write conversion failure diagnostics into fake dmp files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by kmixter1
Modified:
4 years ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

crash-reporter: write conversion failure diagnostics into fake dmp files Change-Id: I9f1ca92def3e1d0fa43b3bef0f2a72d367953926 BUG=6299, 7782 TEST=bvts Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=503e373

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added log file sending and catching many kinds of errors #

Patch Set 3 : Add signature for error logs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -89 lines) Patch
M crash_collector.h View 3 chunks +14 lines, -4 lines 0 comments Download
M crash_collector.cc View 4 chunks +15 lines, -1 line 0 comments Download
M crash_collector_test.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M crash_sender View 5 chunks +19 lines, -15 lines 0 comments Download
M kernel_collector.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M kernel_collector_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M user_collector.h View 2 1 chunk +19 lines, -6 lines 0 comments Download
M user_collector.cc View 1 2 8 chunks +124 lines, -60 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
kmixter1
4 years, 6 months ago (2010-10-27 00:24:46 UTC) #1
petkov
LGTM http://codereview.chromium.org/4088003/diff/1/2 File user_collector.cc (right): http://codereview.chromium.org/4088003/diff/1/2#newcode290 user_collector.cc:290: file_util::WriteFile(minidump_path, output.c_str(), output.length()); output.data(), in this context.
4 years, 6 months ago (2010-10-27 05:14:42 UTC) #2
kmixter1
PTAL. This is a much larger change now properly supporting sending arbitrary logs to the ...
4 years, 6 months ago (2010-10-28 03:57:07 UTC) #3
petkov
4 years, 6 months ago (2010-10-28 22:21:55 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be