Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: user_collector.h

Issue 4088003: crash-reporter: write conversion failure diagnostics into fake dmp files (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git
Patch Set: Add signature for error logs Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « kernel_collector_test.cc ('k') | user_collector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: user_collector.h
diff --git a/user_collector.h b/user_collector.h
index 7d6c7110faff899e60a57a60cb2e797e81fc3a63..2ed8e6f47f0decd2f7936020e0928538cbddda12 100644
--- a/user_collector.h
+++ b/user_collector.h
@@ -82,27 +82,40 @@ class UserCollector : public CrashCollector {
IdKind kind,
const std::string &status_contents,
int *id);
+
+ void LogCollectionError(const std::string &error_message);
+ void EnqueueCollectionErrorLog(pid_t pid, const std::string &exec_name);
+
bool CopyOffProcFiles(pid_t pid, const FilePath &process_map);
// Determines the crash directory for given pid based on pid's owner,
// and creates the directory if necessary with appropriate permissions.
// Returns true whether or not directory needed to be created, false on
// any failure.
bool GetCreatedCrashDirectory(pid_t pid,
- FilePath *crash_file_path);
+ FilePath *crash_file_path,
+ bool *out_of_capacity);
bool CopyStdinToCoreFile(const FilePath &core_path);
int ForkExecAndPipe(std::vector<const char *> &arguments,
const char *output_file);
- bool ConvertCoreToMinidump(const FilePath &core_path,
- const FilePath &procfs_directory,
- const FilePath &minidump_path,
- const FilePath &temp_directory);
- bool GenerateDiagnostics(pid_t pid, const std::string &exec_name);
+ bool RunCoreToMinidump(const FilePath &core_path,
+ const FilePath &procfs_directory,
+ const FilePath &minidump_path,
+ const FilePath &temp_directory);
+ bool ConvertCoreToMinidump(pid_t pid,
+ const FilePath &container_dir,
+ const FilePath &core_path,
+ const FilePath &minidump_path);
+ bool ConvertAndEnqueueCrash(int pid, const std::string &exec_name,
+ bool *out_of_capacity);
bool generate_diagnostics_;
std::string core_pattern_file_;
std::string our_path_;
bool initialized_;
+ // String containing the current log of crash handling errors.
+ std::string error_log_;
+
static const char *kUserId;
static const char *kGroupId;
};
« no previous file with comments | « kernel_collector_test.cc ('k') | user_collector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698