Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 408713002: Enhance test WidgetTest.GestureHandlerNotSetOnGestureEnd (Closed)

Created:
6 years, 5 months ago by tdanderson
Modified:
6 years, 5 months ago
Reviewers:
sadrul, mohsen
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enhance test WidgetTest.GestureHandlerNotSetOnGestureEnd Enhance the coverage of this unit test to verify that the gesture handler tracked by RootView is always NULL after a ui::ET_GESTURE_END event corresponding to the release of the final touch point has been dispatched. BUG=395397 TEST=WidgetTest.GestureHandlerNotSetOnGestureEnd Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284478

Patch Set 1 #

Patch Set 2 : clarified this was for a single touch point only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -27 lines) Patch
M ui/views/widget/widget_unittest.cc View 1 2 chunks +50 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tdanderson
Sadrul, can you PTAL? Mohsen, can you also have a look since I believe this ...
6 years, 5 months ago (2014-07-19 20:34:49 UTC) #1
sadrul
lgtm
6 years, 5 months ago (2014-07-21 06:38:42 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-21 15:21:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/408713002/20001
6 years, 5 months ago (2014-07-21 15:22:10 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 18:35:58 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 19:37:31 UTC) #6
Message was sent while issue was closed.
Change committed as 284478

Powered by Google App Engine
This is Rietveld 408576698