Enhance test WidgetTest.GestureHandlerNotSetOnGestureEnd

ui/views/widget/widget_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 1926 matching lines @@
       base::TimeDelta(),
       ui::GestureEventDetails(ui::ET_GESTURE_TAP_DOWN, 0, 0));
   widget->OnGestureEvent(&tap_down);
   EXPECT_EQ(view, GetGestureHandler(root_view));
   widget->Hide();
   EXPECT_EQ(NULL, GetGestureHandler(root_view));
 
   widget->Close();
 }
 
-class GestureEndConsumerView : public View {
- private:
-  virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE {
-    if (event->type() == ui::ET_GESTURE_END)
-      event->SetHandled();
-  }
+// Convenience to make constructing a GestureEvent simpler.
+class GestureEventForTest : public ui::GestureEvent {
+ public:
+  GestureEventForTest(ui::EventType type, int x, int y)
+      : GestureEvent(x,
+                     y,
+                     0,
+                     base::TimeDelta(),
+                     ui::GestureEventDetails(type, 0.0f, 0.0f)) {}
 };
 
+// Tests that the |gesture_handler_| member in RootView is always NULL
+// after the dispatch of a ui::ET_GESTURE_END event corresponding to
+// the release of the final touch point on the screen.
 TEST_F(WidgetTest, GestureHandlerNotSetOnGestureEnd) {
   Widget* widget = CreateTopLevelNativeWidget();
   widget->SetBounds(gfx::Rect(0, 0, 300, 300));
-  View* view = new GestureEndConsumerView();
+  EventCountView* view = new EventCountView();
   view->SetBounds(0, 0, 300, 300);
   internal::RootView* root_view =
       static_cast<internal::RootView*>(widget->GetRootView());
   root_view->AddChildView(view);
+  widget->Show();
 
-  widget->Show();
+  // If no gesture handler is set, dispatching only a ui::ET_GESTURE_END
+  // event should not set the gesture handler if the event remains unhandled.
   EXPECT_EQ(NULL, GetGestureHandler(root_view));
-  ui::GestureEvent end(15,
-                       15,
-                       0,
-                       base::TimeDelta(),
-                       ui::GestureEventDetails(ui::ET_GESTURE_END, 0, 0));
+  GestureEventForTest end(ui::ET_GESTURE_END, 15, 15);
   widget->OnGestureEvent(&end);
+  EXPECT_FALSE(end.handled());
+  EXPECT_EQ(NULL, GetGestureHandler(root_view));
+
+  // If no gesture handler is set, dispatching only a ui::ET_GESTURE_END
+  // event should not set the gesture handler event if the event is handled.
+  view->set_handle_mode(EventCountView::CONSUME_EVENTS);
+  end = GestureEventForTest(ui::ET_GESTURE_END, 15, 15);
+  widget->OnGestureEvent(&end);
+  EXPECT_TRUE(end.handled());
+  EXPECT_EQ(NULL, GetGestureHandler(root_view));
+
+  // If the gesture handler has been set by a previous gesture, then
+  // it should be reset to NULL by a ui::ET_GESTURE_END.
+  GestureEventForTest tap(ui::ET_GESTURE_TAP, 15, 15);
+  widget->OnGestureEvent(&tap);
+  EXPECT_TRUE(tap.handled());
+  EXPECT_EQ(view, GetGestureHandler(root_view));
+  end = GestureEventForTest(ui::ET_GESTURE_END, 15, 15);
+  widget->OnGestureEvent(&end);
+  EXPECT_TRUE(end.handled());
+  EXPECT_EQ(NULL, GetGestureHandler(root_view));
+
+  // If the gesture handler has been set by a previous gesture, then
+  // it should be reset to NULL by a ui::ET_GESTURE_END, even when
+  // the gesture handler does not actually handle the end event.
+  tap = GestureEventForTest(ui::ET_GESTURE_TAP, 15, 15);
+  widget->OnGestureEvent(&tap);
+  EXPECT_TRUE(tap.handled());
+  EXPECT_EQ(view, GetGestureHandler(root_view));
+  end = GestureEventForTest(ui::ET_GESTURE_END, 15, 15);
+  view->set_handle_mode(EventCountView::PROPAGATE_EVENTS);
+  widget->OnGestureEvent(&end);
+  EXPECT_FALSE(end.handled());
   EXPECT_EQ(NULL, GetGestureHandler(root_view));
 
   widget->Close();
 }
 
 // Test the result of Widget::GetAllChildWidgets().
 TEST_F(WidgetTest, GetAllChildWidgets) {
   // Create the following widget hierarchy:
   //
   // toplevel
@@ skipping 459 matching lines @@
 
   bool fullscreen_layout_called() const { return fullscreen_layout_called_; }
 
  private:
   views::Widget* widget_;
   bool fullscreen_layout_called_;
 
   DISALLOW_COPY_AND_ASSIGN(FullscreenAwareFrame);
 };
 
-// Convenience to make constructing a GestureEvent simpler.
-class GestureEventForTest : public ui::GestureEvent {
- public:
-  GestureEventForTest(ui::EventType type, int x, int y)
-      : GestureEvent(x,
-                     y,
-                     0,
-                     base::TimeDelta(),
-                     ui::GestureEventDetails(type, 0.0f, 0.0f)) {}
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(GestureEventForTest);
-};
-
 }  // namespace
 
 // Tests that frame Layout is called when a widget goes fullscreen without
 // changing its size or title.
 TEST_F(WidgetTest, FullscreenFrameLayout) {
   Widget* widget = CreateTopLevelPlatformWidget();
   FullscreenAwareFrame* frame = new FullscreenAwareFrame(widget);
   widget->non_client_view()->SetFrameView(frame);  // Owns |frame|.
 
   widget->Maximize();
@@ skipping 117 matching lines @@
   EXPECT_EQ(3, view->GetEventCount(ui::ET_MOUSE_PRESSED));
   EXPECT_EQ(3, view->GetEventCount(ui::ET_MOUSE_RELEASED));
   EXPECT_EQ(1, view->GetEventCount(ui::ET_MOUSE_DRAGGED));
   EXPECT_EQ(ui::EF_LEFT_MOUSE_BUTTON, view->last_flags());
 
   widget->CloseNow();
 }
 
 }  // namespace test
 }  // namespace views