extensions/common/api/sockets/sockets_manifest_permission.h - Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/sockets/sockets_manifest_permission.h

Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src@warnings

Patch Set: More review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc ('k') | extensions/common/api/sockets/sockets_manifest_permission.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/api/sockets/sockets_manifest_permission.h

diff --git a/extensions/common/api/sockets/sockets_manifest_permission.h b/extensions/common/api/sockets/sockets_manifest_permission.h

index f9e7e9ec598803e5b65281c48d2b2b04563217cf..8aa8be20dd8930f8c7fef8ae095b57c5dc922137 100644

--- a/extensions/common/api/sockets/sockets_manifest_permission.h

+++ b/extensions/common/api/sockets/sockets_manifest_permission.h

@@ -46,18 +46,12 @@ class SocketsManifestPermission : public ManifestPermission {

virtual PermissionMessages GetMessages() const OVERRIDE;

virtual bool FromValue(const base::Value* value) OVERRIDE;

virtual scoped_ptr<base::Value> ToValue() const OVERRIDE;

- virtual ManifestPermission* Clone() const OVERRIDE;

virtual ManifestPermission* Diff(const ManifestPermission* rhs) const

OVERRIDE;

virtual ManifestPermission* Union(const ManifestPermission* rhs) const

OVERRIDE;

virtual ManifestPermission* Intersect(const ManifestPermission* rhs) const

OVERRIDE;

- virtual bool Contains(const ManifestPermission* rhs) const OVERRIDE;

- virtual bool Equal(const ManifestPermission* rhs) const OVERRIDE;

- virtual void Write(IPC::Message* m) const OVERRIDE;

- virtual bool Read(const IPC::Message* m, PickleIterator* iter) OVERRIDE;

- virtual void Log(std::string* log) const OVERRIDE;

const SocketPermissionEntrySet& entries() const { return permissions_; }