extensions/common/api/sockets/sockets_manifest_permission.h - Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc

Side by Side Diff: extensions/common/api/sockets/sockets_manifest_permission.h

Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src@warnings

Patch Set: More review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc ('k') | extensions/common/api/sockets/sockets_manifest_permission.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef EXTENSIONS_COMMON_API_SOCKETS_SOCKETS_MANIFEST_PERMISSION_H_	5 #ifndef EXTENSIONS_COMMON_API_SOCKETS_SOCKETS_MANIFEST_PERMISSION_H_

6 #define EXTENSIONS_COMMON_API_SOCKETS_SOCKETS_MANIFEST_PERMISSION_H_	6 #define EXTENSIONS_COMMON_API_SOCKETS_SOCKETS_MANIFEST_PERMISSION_H_

7	7

8 #include <set>	8 #include <set>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 28 matching lines...) Expand all Loading...
39	39

40 void AddPermission(const SocketPermissionEntry& entry);	40 void AddPermission(const SocketPermissionEntry& entry);

41	41

42 // extensions::ManifestPermission overrides.	42 // extensions::ManifestPermission overrides.

43 virtual std::string name() const OVERRIDE;	43 virtual std::string name() const OVERRIDE;

44 virtual std::string id() const OVERRIDE;	44 virtual std::string id() const OVERRIDE;

45 virtual bool HasMessages() const OVERRIDE;	45 virtual bool HasMessages() const OVERRIDE;

46 virtual PermissionMessages GetMessages() const OVERRIDE;	46 virtual PermissionMessages GetMessages() const OVERRIDE;

47 virtual bool FromValue(const base::Value* value) OVERRIDE;	47 virtual bool FromValue(const base::Value* value) OVERRIDE;

48 virtual scoped_ptr<base::Value> ToValue() const OVERRIDE;	48 virtual scoped_ptr<base::Value> ToValue() const OVERRIDE;

49 virtual ManifestPermission* Clone() const OVERRIDE;

50 virtual ManifestPermission* Diff(const ManifestPermission* rhs) const	49 virtual ManifestPermission* Diff(const ManifestPermission* rhs) const

51 OVERRIDE;	50 OVERRIDE;

52 virtual ManifestPermission* Union(const ManifestPermission* rhs) const	51 virtual ManifestPermission* Union(const ManifestPermission* rhs) const

53 OVERRIDE;	52 OVERRIDE;

54 virtual ManifestPermission* Intersect(const ManifestPermission* rhs) const	53 virtual ManifestPermission* Intersect(const ManifestPermission* rhs) const

55 OVERRIDE;	54 OVERRIDE;

56 virtual bool Contains(const ManifestPermission* rhs) const OVERRIDE;

57 virtual bool Equal(const ManifestPermission* rhs) const OVERRIDE;

58 virtual void Write(IPC::Message* m) const OVERRIDE;

59 virtual bool Read(const IPC::Message* m, PickleIterator* iter) OVERRIDE;

60 virtual void Log(std::string* log) const OVERRIDE;

61	55

62 const SocketPermissionEntrySet& entries() const { return permissions_; }	56 const SocketPermissionEntrySet& entries() const { return permissions_; }

63	57

64 private:	58 private:

65 bool AddAnyHostMessage(PermissionMessages& messages) const;	59 bool AddAnyHostMessage(PermissionMessages& messages) const;

66 void AddSubdomainHostMessage(PermissionMessages& messages) const;	60 void AddSubdomainHostMessage(PermissionMessages& messages) const;

67 void AddSpecificHostMessage(PermissionMessages& messages) const;	61 void AddSpecificHostMessage(PermissionMessages& messages) const;

68 void AddNetworkListMessage(PermissionMessages& messages) const;	62 void AddNetworkListMessage(PermissionMessages& messages) const;

69	63

70 SocketPermissionEntrySet permissions_;	64 SocketPermissionEntrySet permissions_;

71 };	65 };

72	66

73 } // namespace extensions	67 } // namespace extensions

74	68

75 #endif // EXTENSIONS_COMMON_API_SOCKETS_SOCKETS_MANIFEST_PERMISSION_H_	69 #endif // EXTENSIONS_COMMON_API_SOCKETS_SOCKETS_MANIFEST_PERMISSION_H_

OLD	NEW