Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2338)

Unified Diff: extensions/common/api/sockets/sockets_manifest_permission.cc

Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src@warnings
Patch Set: More review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/sockets/sockets_manifest_permission.cc
diff --git a/extensions/common/api/sockets/sockets_manifest_permission.cc b/extensions/common/api/sockets/sockets_manifest_permission.cc
index 67ff99f0abf5c025ee63c3c565badb4e755508d1..455d1dad308645537a992deba9d7cbd06caa0ac5 100644
--- a/extensions/common/api/sockets/sockets_manifest_permission.cc
+++ b/extensions/common/api/sockets/sockets_manifest_permission.cc
@@ -223,12 +223,6 @@ scoped_ptr<base::Value> SocketsManifestPermission::ToValue() const {
return scoped_ptr<base::Value>(sockets.ToValue().release()).Pass();
}
-ManifestPermission* SocketsManifestPermission::Clone() const {
- scoped_ptr<SocketsManifestPermission> result(new SocketsManifestPermission());
- result->permissions_ = permissions_;
- return result.release();
-}
-
ManifestPermission* SocketsManifestPermission::Diff(
const ManifestPermission* rhs) const {
const SocketsManifestPermission* other =
@@ -262,34 +256,6 @@ ManifestPermission* SocketsManifestPermission::Intersect(
return result.release();
}
-bool SocketsManifestPermission::Contains(const ManifestPermission* rhs) const {
- const SocketsManifestPermission* other =
- static_cast<const SocketsManifestPermission*>(rhs);
-
- return base::STLIncludes<SocketPermissionEntrySet>(permissions_,
- other->permissions_);
-}
-
-bool SocketsManifestPermission::Equal(const ManifestPermission* rhs) const {
- const SocketsManifestPermission* other =
- static_cast<const SocketsManifestPermission*>(rhs);
-
- return (permissions_ == other->permissions_);
-}
-
-void SocketsManifestPermission::Write(IPC::Message* m) const {
- IPC::WriteParam(m, permissions_);
-}
-
-bool SocketsManifestPermission::Read(const IPC::Message* m,
- PickleIterator* iter) {
- return IPC::ReadParam(m, iter, &permissions_);
-}
-
-void SocketsManifestPermission::Log(std::string* log) const {
- IPC::LogParam(permissions_, log);
-}
-
void SocketsManifestPermission::AddPermission(
const SocketPermissionEntry& entry) {
permissions_.insert(entry);
« no previous file with comments | « extensions/common/api/sockets/sockets_manifest_permission.h ('k') | extensions/common/permissions/manifest_permission.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698