Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.h

Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src@warnings
Patch Set: More review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.h
diff --git a/chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.h b/chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.h
index 06008817b038a435c7b940f1df9bb2debcf04570..5c22645ccaf002bbf695b15fab2963a11d7fe011 100644
--- a/chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.h
+++ b/chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.h
@@ -47,18 +47,12 @@ class BluetoothManifestPermission : public ManifestPermission {
virtual PermissionMessages GetMessages() const OVERRIDE;
virtual bool FromValue(const base::Value* value) OVERRIDE;
virtual scoped_ptr<base::Value> ToValue() const OVERRIDE;
- virtual ManifestPermission* Clone() const OVERRIDE;
virtual ManifestPermission* Diff(const ManifestPermission* rhs)
const OVERRIDE;
virtual ManifestPermission* Union(const ManifestPermission* rhs)
const OVERRIDE;
virtual ManifestPermission* Intersect(const ManifestPermission* rhs)
const OVERRIDE;
- virtual bool Contains(const ManifestPermission* rhs) const OVERRIDE;
- virtual bool Equal(const ManifestPermission* rhs) const OVERRIDE;
- virtual void Write(IPC::Message* m) const OVERRIDE;
- virtual bool Read(const IPC::Message* m, PickleIterator* iter) OVERRIDE;
- virtual void Log(std::string* log) const OVERRIDE;
const BluetoothUuidSet& uuids() const {
return uuids_;
« no previous file with comments | « no previous file | chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698