Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.h

Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src@warnings
Patch Set: More review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_API_BLUETOOTH_BLUETOOTH_MANIFEST_PERMISSION_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_API_BLUETOOTH_BLUETOOTH_MANIFEST_PERMISSION_H_
6 #define CHROME_COMMON_EXTENSIONS_API_BLUETOOTH_BLUETOOTH_MANIFEST_PERMISSION_H_ 6 #define CHROME_COMMON_EXTENSIONS_API_BLUETOOTH_BLUETOOTH_MANIFEST_PERMISSION_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 29 matching lines...) Expand all
40 40
41 void AddPermission(const std::string& uuid); 41 void AddPermission(const std::string& uuid);
42 42
43 // extensions::ManifestPermission overrides. 43 // extensions::ManifestPermission overrides.
44 virtual std::string name() const OVERRIDE; 44 virtual std::string name() const OVERRIDE;
45 virtual std::string id() const OVERRIDE; 45 virtual std::string id() const OVERRIDE;
46 virtual bool HasMessages() const OVERRIDE; 46 virtual bool HasMessages() const OVERRIDE;
47 virtual PermissionMessages GetMessages() const OVERRIDE; 47 virtual PermissionMessages GetMessages() const OVERRIDE;
48 virtual bool FromValue(const base::Value* value) OVERRIDE; 48 virtual bool FromValue(const base::Value* value) OVERRIDE;
49 virtual scoped_ptr<base::Value> ToValue() const OVERRIDE; 49 virtual scoped_ptr<base::Value> ToValue() const OVERRIDE;
50 virtual ManifestPermission* Clone() const OVERRIDE;
51 virtual ManifestPermission* Diff(const ManifestPermission* rhs) 50 virtual ManifestPermission* Diff(const ManifestPermission* rhs)
52 const OVERRIDE; 51 const OVERRIDE;
53 virtual ManifestPermission* Union(const ManifestPermission* rhs) 52 virtual ManifestPermission* Union(const ManifestPermission* rhs)
54 const OVERRIDE; 53 const OVERRIDE;
55 virtual ManifestPermission* Intersect(const ManifestPermission* rhs) 54 virtual ManifestPermission* Intersect(const ManifestPermission* rhs)
56 const OVERRIDE; 55 const OVERRIDE;
57 virtual bool Contains(const ManifestPermission* rhs) const OVERRIDE;
58 virtual bool Equal(const ManifestPermission* rhs) const OVERRIDE;
59 virtual void Write(IPC::Message* m) const OVERRIDE;
60 virtual bool Read(const IPC::Message* m, PickleIterator* iter) OVERRIDE;
61 virtual void Log(std::string* log) const OVERRIDE;
62 56
63 const BluetoothUuidSet& uuids() const { 57 const BluetoothUuidSet& uuids() const {
64 return uuids_; 58 return uuids_;
65 } 59 }
66 60
67 private: 61 private:
68 BluetoothUuidSet uuids_; 62 BluetoothUuidSet uuids_;
69 bool socket_; 63 bool socket_;
70 bool low_energy_; 64 bool low_energy_;
71 }; 65 };
72 66
73 } // namespace extensions 67 } // namespace extensions
74 68
75 #endif // CHROME_COMMON_EXTENSIONS_API_BLUETOOTH_BLUETOOTH_MANIFEST_PERMISSION_ H_ 69 #endif // CHROME_COMMON_EXTENSIONS_API_BLUETOOTH_BLUETOOTH_MANIFEST_PERMISSION_ H_
OLDNEW
« no previous file with comments | « no previous file | chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698