Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: extensions/common/permissions/manifest_permission.h

Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src@warnings
Patch Set: Remove DCHECK Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/manifest_permission.h
diff --git a/extensions/common/permissions/manifest_permission.h b/extensions/common/permissions/manifest_permission.h
index af9e0357037f56e6e9a82f6e0142587edd1960ab..fdfb3f4b383bc72e8b0673a7f05eeaabffd98c6b 100644
--- a/extensions/common/permissions/manifest_permission.h
+++ b/extensions/common/permissions/manifest_permission.h
@@ -50,7 +50,7 @@ class ManifestPermission {
virtual scoped_ptr<base::Value> ToValue() const = 0;
// Clones this.
- virtual ManifestPermission* Clone() const = 0;
+ ManifestPermission* Clone() const;
// Returns a new manifest permission which equals this - |rhs|.
virtual ManifestPermission* Diff(const ManifestPermission* rhs) const = 0;
@@ -64,20 +64,20 @@ class ManifestPermission {
const = 0;
// Returns true if |rhs| is a subset of this.
- virtual bool Contains(const ManifestPermission* rhs) const = 0;
+ bool Contains(const ManifestPermission* rhs) const;
// Returns true if |rhs| is equal to this.
- virtual bool Equal(const ManifestPermission* rhs) const = 0;
+ bool Equal(const ManifestPermission* rhs) const;
// IPC functions
// Writes this into the given IPC message |m|.
- virtual void Write(IPC::Message* m) const = 0;
+ void Write(IPC::Message* m) const;
// Reads from the given IPC message |m|.
- virtual bool Read(const IPC::Message* m, PickleIterator* iter) = 0;
+ bool Read(const IPC::Message* m, PickleIterator* iter);
// Logs this permission.
- virtual void Log(std::string* log) const = 0;
+ void Log(std::string* log) const;
private:
DISALLOW_COPY_AND_ASSIGN(ManifestPermission);

Powered by Google App Engine
This is Rietveld 408576698