Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc

extensions/common/manifest_handler.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLER_H_
 #define EXTENSIONS_COMMON_MANIFEST_HANDLER_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 105 matching lines @@
  private:
   // The keys to register us for (in Register).
   virtual const std::vector<std::string> Keys() const = 0;
 };
 
 // The global registry for manifest handlers.
 class ManifestHandlerRegistry {
  private:
   friend class ManifestHandler;
   friend class ScopedTestingManifestHandlerRegistry;
+  friend class MockManifestHandlerRegistry;
   friend struct base::DefaultLazyInstanceTraits<ManifestHandlerRegistry>;
 
   ManifestHandlerRegistry();
   ~ManifestHandlerRegistry();
 
   void Finalize();
 
   void RegisterManifestHandler(const std::string& key,
                                linked_ptr<ManifestHandler> handler);
   bool ParseExtension(Extension* extension, base::string16* error);
   bool ValidateExtension(const Extension* extension,
                          std::string* error,
                          std::vector<InstallWarning>* warnings);
 
-  ManifestPermission* CreatePermission(const std::string& key);
+  virtual ManifestPermission* CreatePermission(const std::string& key);

[not at google - send to devlin, 2014/07/18 22:02:18]

see comment in manifest_permission.cc. it's a shame to be making this virtual
just for testing (and FYI the destructor needs to be virtual too).

[aboxhall, 2014/07/18 22:38:16]

Acknowledged.

 
   void AddExtensionInitialRequiredPermissions(
       const Extension* extension,
       ManifestPermissionSet* permission_set);
 
   // Overrides the current global ManifestHandlerRegistry with
   // |registry|, returning the current one.
   static ManifestHandlerRegistry* SetForTesting(
       ManifestHandlerRegistry* new_registry);
 
@@ skipping 13 matching lines @@
   // The priority for each manifest handler. Handlers with lower priority
   // values are evaluated first.
   ManifestHandlerPriorityMap priority_map_;
 
   bool is_finalized_;
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_MANIFEST_HANDLER_H_