Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 408483005: Fix double-offset issue of RenderObject::positionFromPaintInvalidationContainer() (Closed)

Created:
6 years, 5 months ago by Xianzhu
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Fix double-offset issue of RenderObject::positionFromPaintInvalidationContainer() As currently we only use positionFromPaintInvalidationContainer to check if it has changed, neither the issue nor the fix visibly affects any behavior. The fix is required by https://codereview.chromium.org/399173005. Also removed roundedIntPoint because now we pass sub-pixel coordinates to GraphicsLayer for invalidations (after https://codereview.chromium.org/353403006/). BUG=395217 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178503

Patch Set 1 #

Patch Set 2 : Fix break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/core/rendering/RenderObject.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Xianzhu
6 years, 5 months ago (2014-07-18 18:52:11 UTC) #1
Julien - ping for review
lgtm
6 years, 5 months ago (2014-07-18 21:23:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/408483005/1
6 years, 5 months ago (2014-07-18 21:24:15 UTC) #3
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 5 months ago (2014-07-18 22:16:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/408483005/20001
6 years, 5 months ago (2014-07-18 22:16:15 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 23:37:54 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 00:10:27 UTC) #7
Message was sent while issue was closed.
Change committed as 178503

Powered by Google App Engine
This is Rietveld 408576698