Incrementally invalidate boxes with borders if possible

Incrementally invalidate boxes with borders if possible

This actually restores RenderBox::incrementallyInvalidatePaint()
which was removed in http://src.chromium.org/viewvc/blink?view=revision&revision=177971
because it was buggy.

This change handles borders and border-radius.

BUG=390587
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180596

[Xianzhu, 2014-07-21 22:49:02]

Incremental invalidation for box-shadow, outline and border-image-outsets will
be added in later changes.

[Xianzhu, 2014-07-23 16:47:14]

ping...

[esprehn, 2014-08-19 01:59:12]

lgtm, do we have a good sense if all of this incremental invalidation is
improving performance?

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
File Source/core/rendering/RenderBox.cpp (right):

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
Source/core/rendering/RenderBox.cpp:4085: // radius width/height, we cannot use
incremental invalidation.
Why is this?

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
Source/core/rendering/RenderBox.cpp:4119: && oldBorderBoxSize ==
oldBounds.size() && newBorderBoxSize == newBounds.size())
one statement per line might make this easier to read.

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
Source/core/rendering/RenderBox.cpp:4123: LayoutUnit deltaWidth =
absoluteValue(oldBorderBoxSize.width() - newBorderBoxSize.width());
= not () for initialization, it's nice to be consistent.

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
File Source/core/rendering/RenderBox.h (right):

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
Source/core/rendering/RenderBox.h:731: LayoutSize getPreviousBorderBoxSize(const
LayoutSize& previousBoundsSize) const;
no get(), computePreviousBorderBoxSize(...) ?

[Xianzhu, 2014-08-19 16:06:20]

Some reasons of the patch:
- It brings back part of the original incremental invalidation code what was
disabled because of its bugs;
- A discussion in graphics-dev showed the less/smaller invalidation the better;
whole-tile repainting in impl-side-painting mode may reduce the benefit of
smaller invalidation, but we should separate them into different issues;
- It will help very much for size-animation of a box having border.

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
File Source/core/rendering/RenderBox.cpp (right):

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
Source/core/rendering/RenderBox.cpp:4085: // radius width/height, we cannot use
incremental invalidation.
On 2014/08/19 01:59:12, esprehn wrote:
> Why is this?

Modified comments to state the reason.

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
Source/core/rendering/RenderBox.cpp:4119: && oldBorderBoxSize ==
oldBounds.size() && newBorderBoxSize == newBounds.size())
On 2014/08/19 01:59:12, esprehn wrote:
> one statement per line might make this easier to read.

Done.

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
Source/core/rendering/RenderBox.cpp:4123: LayoutUnit deltaWidth =
absoluteValue(oldBorderBoxSize.width() - newBorderBoxSize.width());
On 2014/08/19 01:59:12, esprehn wrote:
> = not () for initialization, it's nice to be consistent.

'=' is used in most cases except that the constructor receives multiple
arguments.

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
File Source/core/rendering/RenderBox.h (right):

https://codereview.chromium.org/399173005/diff/60001/Source/core/rendering/Re...
Source/core/rendering/RenderBox.h:731: LayoutSize getPreviousBorderBoxSize(const
LayoutSize& previousBoundsSize) const;
On 2014/08/19 01:59:12, esprehn wrote:
> no get(), computePreviousBorderBoxSize(...) ?

Done.

[Xianzhu, 2014-08-19 16:22:24]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-19 16:23:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/399173005/80001

[Xianzhu, 2014-08-19 16:43:26]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-19 16:44:39]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/399173005/100001

[commit-bot: I haz the power, 2014-08-19 16:49:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/20413)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23487)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/43682)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/48855)

[Xianzhu, 2014-08-19 16:50:45]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-19 16:51:01]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/399173005/120001

[commit-bot: I haz the power, 2014-08-19 17:35:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-08-19 17:48:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-19 17:48:57]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)

[Xianzhu, 2014-08-19 17:51:24]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-19 17:51:36]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/399173005/140001

[commit-bot: I haz the power, 2014-08-19 19:00:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23501)

[commit-bot: I haz the power, 2014-08-19 19:45:15]

Committed patchset #7 (140001) as 180596