Issue 408313002: Merge 279172 "Proper fix for accessibility in Windows 64 build."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 408313002: Merge 279172 "Proper fix for accessibility in Windows 64 build." (Closed)

Created:
6 years, 5 months ago by dmazzoni

Modified:
6 years, 5 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge 279172 "Proper fix for accessibility in Windows 64 build." > Proper fix for accessibility in Windows 64 build. > > The previous fix didn't handle all clients. How l_param is > sign-extended to 64-bits depends on the client, so we have > to handle both correct and incorrect conversion to 64-bits. > > BUG=383240 > TBR=jam,sky > > Review URL: https://codereview.chromium.org/347743002 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284747

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -12 lines)			Patch
M	content/browser/renderer_host/legacy_render_widget_host_win.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	ui/views/accessibility/native_view_accessibility_win.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r284747.

Expand Messages | Collapse Messages