Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 347743002: Proper fix for accessibility in Windows 64 build. (Closed)

Created:
6 years, 6 months ago by dmazzoni
Modified:
6 years, 6 months ago
Reviewers:
jschuh, jam, sky
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Proper fix for accessibility in Windows 64 build. The previous fix didn't handle all clients. How l_param is sign-extended to 64-bits depends on the client, so we have to handle both correct and incorrect conversion to 64-bits. BUG=383240 TBR=jam,sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279172

Patch Set 1 #

Total comments: 2

Patch Set 2 : Two casts on one line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dmazzoni
6 years, 6 months ago (2014-06-19 06:13:52 UTC) #1
jschuh
https://codereview.chromium.org/347743002/diff/1/content/browser/renderer_host/legacy_render_widget_host_win.cc File content/browser/renderer_host/legacy_render_widget_host_win.cc (right): https://codereview.chromium.org/347743002/diff/1/content/browser/renderer_host/legacy_render_widget_host_win.cc#newcode139 content/browser/renderer_host/legacy_render_widget_host_win.cc:139: DWORD obj_id = static_cast<DWORD>(unsigned_l_param); I'd just stack the casts ...
6 years, 6 months ago (2014-06-19 09:15:19 UTC) #2
dmazzoni
Done.
6 years, 6 months ago (2014-06-23 06:35:25 UTC) #3
jschuh
lgtm
6 years, 6 months ago (2014-06-23 19:42:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/347743002/20001
6 years, 6 months ago (2014-06-23 19:44:14 UTC) #5
dmazzoni
The CQ bit was unchecked by dmazzoni@chromium.org
6 years, 6 months ago (2014-06-23 19:49:51 UTC) #6
dmazzoni
+jam, sky (TBR OWNERS review)
6 years, 6 months ago (2014-06-23 19:50:48 UTC) #7
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 6 months ago (2014-06-23 19:50:53 UTC) #8
dmazzoni
6 years, 6 months ago (2014-06-23 19:51:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/347743002/20001
6 years, 6 months ago (2014-06-23 19:52:22 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 20:39:03 UTC) #11
Message was sent while issue was closed.
Change committed as 279172

Powered by Google App Engine
This is Rietveld 408576698