Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 408253004: Script crashes with "TypeError: int() argument must be a string or a number, not 'NoneType'" message (Closed)

Created:
6 years, 5 months ago by pshenoy
Modified:
6 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, anantha
Project:
chromium
Visibility:
Public.

Description

Fix bisect-builds.py crash when no bad build is given and GetSVNRevisionFromGitHash returns None. Script crashes with "TypeError: int() argument must be a string or a number, not 'NoneType'" message. The fix is to use 'raise ValueError' instead of returning None. BUG=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/bisect-builds.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pshenoy
6 years, 5 months ago (2014-07-22 18:29:13 UTC) #1
Robert Sesek
LGTM Please make the first line of your CL description a short summary of the ...
6 years, 5 months ago (2014-07-23 14:26:23 UTC) #2
pshenoy
On 2014/07/23 14:26:23, rsesek wrote: > LGTM > > Please make the first line of ...
6 years, 5 months ago (2014-07-23 16:38:03 UTC) #3
pshenoy
The CQ bit was checked by pshenoy@chromium.org
6 years, 5 months ago (2014-07-23 16:39:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/408253004/1
6 years, 5 months ago (2014-07-23 16:41:29 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 16:44:18 UTC) #6
Message was sent while issue was closed.
Change committed as 284953

Powered by Google App Engine
This is Rietveld 408576698