Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tools/bisect-builds.py

Issue 408253004: Script crashes with "TypeError: int() argument must be a string or a number, not 'NoneType'" message (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-builds.py
diff --git a/tools/bisect-builds.py b/tools/bisect-builds.py
index ad1907b78821e1a072ce69eb1b22e13416697c2f..2ed09678a7420dddfb383fe77e1ac20fb55d8f83 100755
--- a/tools/bisect-builds.py
+++ b/tools/bisect-builds.py
@@ -269,7 +269,7 @@ class PathContext(object):
if result:
return result.group(1)
print 'Failed to get svn revision number for %s' % git_sha1
- return None
+ raise ValueError
def _GetSVNRevisionFromGitHashFromGitCheckout(self, git_sha1, depot):
def _RunGit(command, path):
@@ -294,7 +294,7 @@ class PathContext(object):
(git_output, return_code) = _RunGit(command, path)
if not return_code:
return git_output.strip('\n')
- return None
+ raise ValueError
else:
print ('Script should be run from src folder. ' +
'Eg: python tools/bisect-builds.py -g 280588 -b 280590' +
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698