Issue 40823002: Rebaseline bindings test results after r160442

Issue 40823002: Rebaseline bindings test results after r160442 (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
haraken, Nils Barth (inactive), abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Rebaseline bindings test results after r160442 info was renamed to wrapperTypeInfo. TBR=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160470

Patch Set 1 #

Patch Set 2 : No change #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/bindings/tests/results/V8TestObjectPython.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/40823002/30001

7 years, 2 months ago (2013-10-24 17:33:36 UTC) #3

Nils Barth (inactive)

7 years, 1 month ago (2013-10-28 07:39:07 UTC) #6

Message was sent while issue was closed.

For reference:
This issue sparked a thread on blink-dev:
"git cl upload > run-bindings-tests failed"
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hQ2hqTZyLOw

It is due to two CLs landing at the same time:
1. IDL compiler: constructor attributes
https://codereview.chromium.org/36793003/
2. IDL compiler: rename WrapperTypeInfo info => wrapperTypeInfo
https://codereview.chromium.org/39393004/

1 (constructor attributes) added a new test,
2 (rename) changed output of existing tests.
Thus, while both passed run-bindings-tests when they were submitted, after they
both landed the new test still had the old output, and the tests failed.

To make this simpler to handle in future, I changed the
error message to be more actionable:
run-bindings-tests: better error message
https://codereview.chromium.org/43033002/

Expand Messages | Collapse Messages