Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 408183003: Express LoadIC extra ic state with LoadIC::State (Closed)

Created:
6 years, 5 months ago by mvstanton
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Express LoadIC extra ic state with LoadIC::State Soon we will create code stubs that need to match LoadIC state. It's easier to express if the state is encapsulated in a single class rather than multiple bit fields. Also, eliminate ContextualMode as it's a synonym for TypeofState. R=verwaest@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Removed ContextualMode. #

Patch Set 3 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -94 lines) Patch
M src/arm/codegen-arm.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 7 chunks +10 lines, -14 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 7 chunks +10 lines, -13 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/disassembler.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/full-codegen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 7 chunks +10 lines, -15 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic.h View 1 4 chunks +35 lines, -16 lines 0 comments Download
M src/objects.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/stub-cache.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/codegen-x64.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 7 chunks +10 lines, -14 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mvstanton
Hi Toon, Here is the CL we discussed, thanks for the look! --Michael
6 years, 5 months ago (2014-07-22 16:13:20 UTC) #1
Toon Verwaest
6 years, 5 months ago (2014-07-23 11:06:46 UTC) #2
As discussed offline, please mark all loads properly as not inside typeof when
they are not. That'll require you to check IsGlobalObject() whenever you want to
check the typeof flag. Perhaps do something like:

function IsContextLoad(o) { return IsGlobalObject(o); }
function IsReferenceError(it) {
  return !it->IsFound() &&
         IsContextLoad(it->GetReceiver()) &&
         !target()->inside_typeof();
}

Powered by Google App Engine
This is Rietveld 408576698