Express LoadIC extra ic state with LoadIC::State

src/ic.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_IC_H_
 #define V8_IC_H_
 
 #include "src/macro-assembler.h"
 
 namespace v8 {
@@ skipping 362 matching lines @@
   static void Clear(Isolate* isolate, Address address, Code* target,
                     ConstantPoolArray* constant_pool);
 };
 
 
 OStream& operator<<(OStream& os, const CallIC::State& s);
 
 
 class LoadIC: public IC {
  public:
-  // ExtraICState bits
-  class ContextualModeBits: public BitField<ContextualMode, 0, 1> {};
-  STATIC_ASSERT(static_cast<int>(NOT_CONTEXTUAL) == 0);
 
   enum ParameterIndices {
     kReceiverIndex,
     kNameIndex,
     kParameterCount
   };
   static const Register ReceiverRegister();
   static const Register NameRegister();
 
   // With flag vector-ics, there is an additional argument. And for calls from
   // crankshaft, yet another.
   static const Register SlotRegister();
   static const Register VectorRegister();
 
-  static ExtraICState ComputeExtraICState(ContextualMode contextual_mode) {
-    return ContextualModeBits::encode(contextual_mode);
+  class State V8_FINAL BASE_EMBEDDED {
+   public:
+    explicit State(ExtraICState extra_ic_state)
+        : typeof_state_(TypeofStateBits::decode(extra_ic_state)) {}
+
+    State(TypeofState typeof_state) : typeof_state_(typeof_state) {}
+
+    ExtraICState GetExtraICState() const {
+      return TypeofStateBits::encode(typeof_state_);
+    }
+
+    TypeofState typeof_state() const {
+      return typeof_state_;
+    }
+
+   private:
+    class TypeofStateBits: public BitField<TypeofState, 0, 1> {};
+    STATIC_ASSERT(static_cast<int>(INSIDE_TYPEOF) == 0);
+
+    const TypeofState typeof_state_;
+  };
+
+  static ExtraICState ComputeExtraICState(TypeofState typeof_state) {
+    return State(typeof_state).GetExtraICState();
   }
 
-  static ContextualMode GetContextualMode(ExtraICState state) {
-    return ContextualModeBits::decode(state);
+  static TypeofState GetTypeofState(ExtraICState state) {
+    return State(state).typeof_state();
   }
 
-  ContextualMode contextual_mode() const {
-    return ContextualModeBits::decode(extra_ic_state());
+  TypeofState typeof_state() const {
+    return GetTypeofState(extra_ic_state());
   }
 
   explicit LoadIC(FrameDepth depth, Isolate* isolate)
       : IC(depth, isolate) {
     ASSERT(IsLoadStub());
   }
 
-  // Returns if this IC is for contextual (no explicit receiver)
-  // access to properties.
+  // Returns true if the receiver is the global object accessed outside of a
+  // typeof scope.
   bool IsUndeclaredGlobal(Handle<Object> receiver) {
     if (receiver->IsGlobalObject()) {
-      return contextual_mode() == CONTEXTUAL;
+      return typeof_state() == NOT_INSIDE_TYPEOF;
     } else {
-      ASSERT(contextual_mode() != CONTEXTUAL);
+      ASSERT(typeof_state() == INSIDE_TYPEOF);
       return false;
     }
   }
 
   // Code generator routines.
   static void GenerateInitialize(MacroAssembler* masm) { GenerateMiss(masm); }
   static void GeneratePreMonomorphic(MacroAssembler* masm) {
     GenerateMiss(masm);
   }
   static void GenerateMiss(MacroAssembler* masm);
   static void GenerateMegamorphic(MacroAssembler* masm);
   static void GenerateNormal(MacroAssembler* masm);
   static void GenerateRuntimeGetProperty(MacroAssembler* masm);
 
   static Handle<Code> initialize_stub(Isolate* isolate,
                                       ExtraICState extra_state);
 
   MUST_USE_RESULT MaybeHandle<Object> Load(Handle<Object> object,
                                            Handle<String> name);
 
  protected:
   virtual Code::Kind kind() const { return Code::LOAD_IC; }
 
   void set_target(Code* code) {
-    // The contextual mode must be preserved across IC patching.
-    ASSERT(GetContextualMode(code->extra_ic_state()) ==
-           GetContextualMode(target()->extra_ic_state()));
+    // The typeof state must be preserved across IC patching.
+    ASSERT(GetTypeofState(code->extra_ic_state()) ==
+           GetTypeofState(target()->extra_ic_state()));
 
     IC::set_target(code);
   }
 
   virtual Handle<Code> slow_stub() const {
     return isolate()->builtins()->LoadIC_Slow();
   }
 
   virtual Handle<Code> megamorphic_stub();
   virtual Handle<Code> generic_stub() const;
@@ skipping 574 matching lines @@
 DECLARE_RUNTIME_FUNCTION(ElementsTransitionAndStoreIC_Miss);
 DECLARE_RUNTIME_FUNCTION(BinaryOpIC_Miss);
 DECLARE_RUNTIME_FUNCTION(BinaryOpIC_MissWithAllocationSite);
 DECLARE_RUNTIME_FUNCTION(CompareNilIC_Miss);
 DECLARE_RUNTIME_FUNCTION(ToBooleanIC_Miss);
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_IC_H_