Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 408183002: Update test and rebaseline (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Properly throw in strict mode #

Patch Set 3 : Update more test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/objects.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M test/webkit/fast/js/primitive-property-access-edge-cases-expected.txt View 1 2 chunks +9 lines, -9 lines 0 comments Download
M test/webkit/fast/js/read-modify-eval-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-22 09:20:55 UTC) #1
Igor Sheludko
lgtm
6 years, 5 months ago (2014-07-22 09:24:22 UTC) #2
Toon Verwaest
6 years, 5 months ago (2014-07-22 09:45:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r22520 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698