Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: src/objects.cc

Issue 408183002: Update test and rebaseline (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update more test expectations Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/webkit/fast/js/primitive-property-access-edge-cases-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 9939927222578657e4f83921efb374506f39175f..0f9ea21d378b541e211b3939028ffeac31b49f37 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -3107,8 +3107,10 @@ MaybeHandle<Object> Object::AddDataProperty(LookupIterator* it,
StrictMode strict_mode,
StoreFromKeyed store_mode) {
ASSERT(!it->GetReceiver()->IsJSProxy());
- // Transitions to data properties of value wrappers are not observable.
- if (!it->GetReceiver()->IsJSObject()) return value;
+ if (!it->GetReceiver()->IsJSObject()) {
+ // TODO(verwaest): Throw a TypeError with a more specific message.
+ return WriteToReadOnlyProperty(it, value, strict_mode);
+ }
Handle<JSObject> receiver = Handle<JSObject>::cast(it->GetReceiver());
// If the receiver is a JSGlobalProxy, store on the prototype (JSGlobalObject)
« no previous file with comments | « no previous file | test/webkit/fast/js/primitive-property-access-edge-cases-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698