Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 408017: GTK: Fix popup menu positioning.... (Closed)

Created:
11 years, 1 month ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

GTK: Fix popup menu positioning. Don't go off end of screen. push_in doesn't actually work as well as one might hope. BUG=27800 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32449

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/gtk/menu_gtk.cc View 1 chunk +8 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
11 years, 1 month ago (2009-11-19 00:34:17 UTC) #1
Evan Martin
http://codereview.chromium.org/408017/diff/1/2 File chrome/browser/gtk/menu_gtk.cc (right): http://codereview.chromium.org/408017/diff/1/2#newcode328 Line 328: GdkScreen* screen = gdk_screen_get_default(); Isn't this wrong if ...
11 years, 1 month ago (2009-11-19 00:40:31 UTC) #2
Evan Stade
http://codereview.chromium.org/408017/diff/1/2 File chrome/browser/gtk/menu_gtk.cc (right): http://codereview.chromium.org/408017/diff/1/2#newcode328 Line 328: GdkScreen* screen = gdk_screen_get_default(); On 2009/11/19 00:40:32, Evan ...
11 years, 1 month ago (2009-11-19 00:46:18 UTC) #3
Evan Martin
On 2009/11/19 00:46:18, Evan Stade wrote: > http://codereview.chromium.org/408017/diff/1/2 > File chrome/browser/gtk/menu_gtk.cc (right): > > http://codereview.chromium.org/408017/diff/1/2#newcode328 ...
11 years, 1 month ago (2009-11-19 00:48:42 UTC) #4
Evan Stade
11 years, 1 month ago (2009-11-19 01:05:48 UTC) #5
"The default menu positioning function will position the menu at the
current mouse cursor position."

This is wrong for when users press the menu button, which is the
reason this code changed in the first place.

-- Evan Stade



On Wed, Nov 18, 2009 at 4:48 PM,  <evan@chromium.org> wrote:
> On 2009/11/19 00:46:18, Evan Stade wrote:
>>
>> http://codereview.chromium.org/408017/diff/1/2
>> File chrome/browser/gtk/menu_gtk.cc (right):
>
>> http://codereview.chromium.org/408017/diff/1/2#newcode328
>> Line 328: GdkScreen* screen = gdk_screen_get_default();
>> On 2009/11/19 00:40:32, Evan Martin wrote:
>> > Isn't this wrong if the menu's on a different screen?
>
>> oh, like a dual monitor setup? didn't think about that. Guess I should
>> just
>
> copy
>>
>> the above code (or factor it out).
>
> I would think the default positioning func would Do The Right Thing
>
> http://codereview.chromium.org/408017
>

Powered by Google App Engine
This is Rietveld 408576698