GTK: Fix popup menu positioning....

GTK: Fix popup menu positioning.

Don't go off end of screen. push_in doesn't actually work as well as one might hope.

BUG=27800
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32449

[Evan Martin, 2009-11-19 00:40:31]

http://codereview.chromium.org/408017/diff/1/2
File chrome/browser/gtk/menu_gtk.cc (right):

http://codereview.chromium.org/408017/diff/1/2#newcode328
Line 328: GdkScreen* screen = gdk_screen_get_default();
Isn't this wrong if the menu's on a different screen?

[Evan Stade, 2009-11-19 00:46:18]

http://codereview.chromium.org/408017/diff/1/2
File chrome/browser/gtk/menu_gtk.cc (right):

http://codereview.chromium.org/408017/diff/1/2#newcode328
Line 328: GdkScreen* screen = gdk_screen_get_default();
On 2009/11/19 00:40:32, Evan Martin wrote:
> Isn't this wrong if the menu's on a different screen?

oh, like a dual monitor setup? didn't think about that. Guess I should just copy
the above code (or factor it out).

[Evan Martin, 2009-11-19 00:48:42]

On 2009/11/19 00:46:18, Evan Stade wrote:
> http://codereview.chromium.org/408017/diff/1/2
> File chrome/browser/gtk/menu_gtk.cc (right):
> 
> http://codereview.chromium.org/408017/diff/1/2#newcode328
> Line 328: GdkScreen* screen = gdk_screen_get_default();
> On 2009/11/19 00:40:32, Evan Martin wrote:
> > Isn't this wrong if the menu's on a different screen?
> 
> oh, like a dual monitor setup? didn't think about that. Guess I should just
copy
> the above code (or factor it out).

I would think the default positioning func would Do The Right Thing

[Evan Stade, 2009-11-19 01:05:48]

"The default menu positioning function will position the menu at the
current mouse cursor position."

This is wrong for when users press the menu button, which is the
reason this code changed in the first place.

-- Evan Stade



On Wed, Nov 18, 2009 at 4:48 PM,  <evan@chromium.org> wrote:
> On 2009/11/19 00:46:18, Evan Stade wrote:
>>
>> http://codereview.chromium.org/408017/diff/1/2
>> File chrome/browser/gtk/menu_gtk.cc (right):
>
>> http://codereview.chromium.org/408017/diff/1/2#newcode328
>> Line 328: GdkScreen* screen = gdk_screen_get_default();
>> On 2009/11/19 00:40:32, Evan Martin wrote:
>> > Isn't this wrong if the menu's on a different screen?
>
>> oh, like a dual monitor setup? didn't think about that. Guess I should
>> just
>
> copy
>>
>> the above code (or factor it out).
>
> I would think the default positioning func would Do The Right Thing
>
> http://codereview.chromium.org/408017
>