GTK: Fix popup menu positioning....

chrome/browser/gtk/menu_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/menu_gtk.h"
 
 #include "app/gfx/gtk_util.h"
 #include "app/l10n_util.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
@@ skipping 304 matching lines @@
 void MenuGtk::PointMenuPositionFunc(GtkMenu* menu,
                                     int* x,
                                     int* y,
                                     gboolean* push_in,
                                     gpointer userdata) {
   *push_in = TRUE;
 
   gfx::Point* point = reinterpret_cast<gfx::Point*>(userdata);
   *x = point->x();
   *y = point->y();
+
+  GtkRequisition menu_req;
+  gtk_widget_size_request(GTK_WIDGET(menu), &menu_req);
+  GdkScreen* screen = gdk_screen_get_default();

[Evan Martin, 2009/11/19 00:40:32]

Isn't this wrong if the menu's on a different screen?

[Evan Stade, 2009/11/19 00:46:18]

oh, like a dual monitor setup? didn't think about that. Guess I should just copy
the above code (or factor it out).

+  gint screen_height = gdk_screen_get_height(screen);
+
+  if (*y + menu_req.height > screen_height)
+    *y -= menu_req.height;
 }
 
 void MenuGtk::UpdateMenu() {
   gtk_container_foreach(GTK_CONTAINER(menu_.get()), SetMenuItemInfo, this);
 }
 
 // static
 void MenuGtk::OnMenuShow(GtkWidget* widget, MenuGtk* menu) {
   MessageLoop::current()->PostTask(FROM_HERE,
       menu->factory_.NewRunnableMethod(&MenuGtk::UpdateMenu));
@@ skipping 46 matching lines @@
     gtk_widget_set_sensitive(
         widget, menu->delegate_->IsCommandEnabled(id));
 
     GtkWidget* submenu = gtk_menu_item_get_submenu(GTK_MENU_ITEM(widget));
     if (submenu) {
       gtk_container_foreach(GTK_CONTAINER(submenu), &SetMenuItemInfo,
                             userdata);
     }
   }
 }