Fix gesture handling for Views textfields

Fix gesture handling for Views textfields

Changing gesture handling in Views textfields to be more consistent with
blink's textfields. The main changes are:
 - Dragging text scrolls the text in textfield;
 - Tap on selection activates touch editing;
 - Double-tap selects a word;
 - Triple-tap selects the entire text;
 - Long-press off selection selects a word;
 - Long-press on selection starts drag-drop (if drag-drop is enabled) or
   shows context menu (if drag-drop is disabled);
 - Long-tap shows context menu, if drag-drop started on the
   corresponding long-press was not exercised.

BUG=388862
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284875

[mohsen, 2014-07-21 20:26:30]

Please take a look...

[sky, 2014-07-21 22:37:44]

https://codereview.chromium.org/407993003/diff/40001/ui/gfx/render_text.cc
File ui/gfx/render_text.cc (right):

https://codereview.chromium.org/407993003/diff/40001/ui/gfx/render_text.cc#ne...
ui/gfx/render_text.cc:895: min_offset = -(extra_content + 1) / 2;
Why do you need to do this change?

https://codereview.chromium.org/407993003/diff/40001/ui/views/controls/textfi...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/407993003/diff/40001/ui/views/controls/textfi...
ui/views/controls/textfield/textfield.cc:758:
touch_handles_hidden_due_to_scroll_ = touch_selection_controller_;
I'm surprised you don't get a compile warning here.

[mohsen, 2014-07-21 23:07:57]

https://codereview.chromium.org/407993003/diff/40001/ui/gfx/render_text.cc
File ui/gfx/render_text.cc (right):

https://codereview.chromium.org/407993003/diff/40001/ui/gfx/render_text.cc#ne...
ui/gfx/render_text.cc:895: min_offset = -(extra_content + 1) / 2;
On 2014/07/21 22:37:43, sky wrote:
> Why do you need to do this change?

This is an off-by-one pixel bug I had in my previous CL (r282308). I'm fixing it
in a separate CL (crrev.com/384953003). I included it in here so that this CL
works properly before the other one lands.

Removed it since it is not really part of this CL.

https://codereview.chromium.org/407993003/diff/40001/ui/views/controls/textfi...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/407993003/diff/40001/ui/views/controls/textfi...
ui/views/controls/textfield/textfield.cc:758:
touch_handles_hidden_due_to_scroll_ = touch_selection_controller_;
On 2014/07/21 22:37:43, sky wrote:
> I'm surprised you don't get a compile warning here.

Really? Didn't know it's not allowed. Fixed.

[sky, 2014-07-21 23:33:54]

LGTM

[mohsen, 2014-07-22 18:01:00]

I have made a small change in OmniboxViewViews::OnGestureEVent(). Can you take a
quick look, please?

[sky, 2014-07-22 18:22:02]

SLGTM

[mohsen, 2014-07-23 02:40:25]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2014-07-23 02:41:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mohsen@chromium.org/407993003/140001

[commit-bot: I haz the power, 2014-07-23 06:57:42]

Change committed as 284875