Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 407993003: Fix gesture handling for Views textfields (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/textfield/textfield.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index 274290c72a953895745219f8fb9b9a4d075cd3e6..f4137c08f6f976610863171d5713c15e70b0544c 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -764,8 +764,10 @@ void OmniboxViewViews::OnGestureEvent(ui::GestureEvent* event) {
saved_selection_for_focus_change_ = gfx::Range::InvalidRange();
}
+ views::Textfield::OnGestureEvent(event);
+
if (select_all_on_gesture_tap_ && event->type() == ui::ET_GESTURE_TAP)
- SelectAll(false);
+ SelectAll(true);
if (event->type() == ui::ET_GESTURE_TAP ||
event->type() == ui::ET_GESTURE_TAP_CANCEL ||
@@ -776,8 +778,6 @@ void OmniboxViewViews::OnGestureEvent(ui::GestureEvent* event) {
event->type() == ui::ET_GESTURE_LONG_TAP) {
select_all_on_gesture_tap_ = false;
}
-
- views::Textfield::OnGestureEvent(event);
}
void OmniboxViewViews::AboutToRequestFocusFromTabTraversal(bool reverse) {
« no previous file with comments | « no previous file | ui/views/controls/textfield/textfield.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698