Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 4078003: Refactoring select popup on Mac.... (Closed)

Created:
10 years, 1 month ago by Jay Civelli
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Refactoring select popup on Mac. The select popup on Mac was based on a hack: we would create an invisible RenderWidget and redirect mouse and keyboard events to it and we would display a native Cocoa menu. With this CL we do not use a RenderWidget anymore, we send the user selection to the RenderView which in turns communicates to WebKit that selection. BUG=None TEST=On Mac, ensures the select popup works as expected. Also test that for an extension with a browser action containing a select popup, the select popup does work. Also ensures autocomplete/autofill still works (especially popups). Original review: http://codereview.chromium.org/3795006/show Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -157 lines) Patch
M chrome/browser/background_contents_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host_mac.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/notifications/balloon_host.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 3 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 5 chunks +1 line, -21 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 4 chunks +15 lines, -104 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 3 chunks +18 lines, -2 lines 0 comments Download
A chrome/browser/tab_contents/popup_menu_helper_mac.h View 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/browser/tab_contents/popup_menu_helper_mac.mm View 1 chunk +87 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 3 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_gtk.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_gtk.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/renderer/external_popup_menu.h View 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/renderer/external_popup_menu.cc View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/renderer/external_popup_menu_unittest.cc View 1 chunk +98 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.h View 5 chunks +13 lines, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 5 chunks +22 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_main.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/render_view_test.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/render_view_test.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698