Give StatusTrayStateChangerProxy a virtual destructor.

Give StatusTrayStateChangerProxy a virtual destructor.

This type has subclasses and is destroyed polymorphically, so the destructor
needs to be in the vtable. Found by clang.

Follow-up to https://codereview.chromium.org/252513004/

BUG=347693, 82385
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284352

[Nico, 2014-07-18 23:05:09]

Sounds like dewittj is away for a while, so I gave this a shot myself.

[sky, 2014-07-18 23:06:59]

LGTM

https://codereview.chromium.org/407653002/diff/1/chrome/browser/ui/views/stat...
File chrome/browser/ui/views/status_icons/status_tray_win.cc (right):

https://codereview.chromium.org/407653002/diff/1/chrome/browser/ui/views/stat...
chrome/browser/ui/views/status_icons/status_tray_win.cc:30:
StatusTrayStateChangerProxy::~StatusTrayStateChangerProxy() {
I would inline this.

[Nico, 2014-07-19 00:24:12]

Thanks!

https://codereview.chromium.org/407653002/diff/1/chrome/browser/ui/views/stat...
File chrome/browser/ui/views/status_icons/status_tray_win.cc (right):

https://codereview.chromium.org/407653002/diff/1/chrome/browser/ui/views/stat...
chrome/browser/ui/views/status_icons/status_tray_win.cc:30:
StatusTrayStateChangerProxy::~StatusTrayStateChangerProxy() {
On 2014/07/18 23:06:59, sky wrote:
> I would inline this.

Done. (On posix, having an out-of-line destructor can be nice since a key
function tells the compiler where to emit its vtable, but for windows-only files
I suppose it doesn't matter.)

[Nico, 2014-07-19 23:34:19]

Committed patchset #2 manually as r284352 (presubmit successful).