Give StatusTrayStateChangerProxy a virtual destructor.

chrome/browser/ui/views/status_icons/status_tray_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/status_icons/status_tray_win.h"
 
 #include <commctrl.h>
 
 #include "base/bind.h"
 #include "base/threading/non_thread_safe.h"
 #include "base/threading/thread.h"
 #include "base/win/wrapped_window_proc.h"
 #include "chrome/browser/ui/views/status_icons/status_icon_win.h"
 #include "chrome/browser/ui/views/status_icons/status_tray_state_changer_win.h"
 #include "chrome/common/chrome_constants.h"
 #include "ui/gfx/screen.h"
 #include "ui/gfx/win/hwnd_util.h"
 
 static const UINT kStatusIconMessage = WM_APP + 1;
 
 namespace {
 // |kBaseIconId| is 2 to avoid conflicts with plugins that hard-code id 1.
 const UINT kBaseIconId = 2;
 
 UINT ReservedIconId(StatusTray::StatusIconType type) {
   return kBaseIconId + static_cast<UINT>(type);
 }
 }  // namespace
 
+StatusTrayStateChangerProxy::~StatusTrayStateChangerProxy() {

[sky, 2014/07/18 23:06:59]

I would inline this.

[Nico, 2014/07/19 00:24:12]

Done. (On posix, having an out-of-line destructor can be nice since a key
function tells the compiler where to emit its vtable, but for windows-only files
I suppose it doesn't matter.)

+}
+
 // Default implementation for StatusTrayStateChanger that communicates to
 // Exporer.exe via COM.  It spawns a background thread with a fresh COM
 // apartment and requests that the visibility be increased unless the user
 // has explicitly set the icon to be hidden.
 class StatusTrayStateChangerProxyImpl : public StatusTrayStateChangerProxy,
                                         public base::NonThreadSafe {
  public:
   StatusTrayStateChangerProxyImpl()
       : pending_requests_(0),
         worker_thread_("StatusIconCOMWorkerThread"),
@@ skipping 181 matching lines @@
 }
 
 void StatusTrayWin::SetStatusTrayStateChangerProxyForTest(
     scoped_ptr<StatusTrayStateChangerProxy> proxy) {
   state_changer_proxy_ = proxy.Pass();
 }
 
 StatusTray* StatusTray::Create() {
   return new StatusTrayWin();
 }