Factor out common vector crosstesting code.

Factor out common vector crosstesting code.

Add vectors.h and vector.def to hold vector type declarations and useful
vector utilities. Change the existing tests to use this new header where
applicable (arith, vector_ops).

BUG=none
R=jvoung@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=89a7c2b

[jvoung (off chromium), 2014-07-18 22:50:40]

https://codereview.chromium.org/407543003/diff/1/crosstest/test_arith.cpp
File crosstest/test_arith.cpp (right):

https://codereview.chromium.org/407543003/diff/1/crosstest/test_arith.cpp#new...
crosstest/test_arith.cpp:6: #include "vectors.h"
Could test_arith.h just be the one to include vectors.h? Then the order doesn't
matter so much (otherwise here you need to include vectors.h before you can
include test_arith.h")

https://codereview.chromium.org/407543003/diff/1/crosstest/test_vector_ops.h
File crosstest/test_vector_ops.h (right):

https://codereview.chromium.org/407543003/diff/1/crosstest/test_vector_ops.h#...
crosstest/test_vector_ops.h:1: #ifndef TEST_VECTOR_OPS_H
Add a #define TEST_VECTOR_OPS_H ?

[wala, 2014-07-18 23:08:23]

https://codereview.chromium.org/407543003/diff/1/crosstest/test_arith.cpp
File crosstest/test_arith.cpp (right):

https://codereview.chromium.org/407543003/diff/1/crosstest/test_arith.cpp#new...
crosstest/test_arith.cpp:6: #include "vectors.h"
On 2014/07/18 22:50:40, jvoung wrote:
> Could test_arith.h just be the one to include vectors.h? Then the order
doesn't
> matter so much (otherwise here you need to include vectors.h before you can
> include test_arith.h")

Done.

https://codereview.chromium.org/407543003/diff/1/crosstest/test_vector_ops.h
File crosstest/test_vector_ops.h (right):

https://codereview.chromium.org/407543003/diff/1/crosstest/test_vector_ops.h#...
crosstest/test_vector_ops.h:1: #ifndef TEST_VECTOR_OPS_H
On 2014/07/18 22:50:40, jvoung wrote:
> Add a #define TEST_VECTOR_OPS_H ?

Woops!! Done.

[Jim Stichnoth, 2014-07-18 23:45:49]

https://codereview.chromium.org/407543003/diff/1/crosstest/test_arith.cpp
File crosstest/test_arith.cpp (right):

https://codereview.chromium.org/407543003/diff/1/crosstest/test_arith.cpp#new...
crosstest/test_arith.cpp:6: #include "vectors.h"
On 2014/07/18 22:50:40, jvoung wrote:
> Could test_arith.h just be the one to include vectors.h? Then the order
doesn't
> matter so much (otherwise here you need to include vectors.h before you can
> include test_arith.h")

There's some stuff in vectors.h that you might be tempted to actually use in the
cross test, which would lead to link errors due to the Subzero_ prefix being
added.  E.g. vectAsString().  So in principle, I would try to minimize the
includes for the cross test.

With that said, if the change still links, then I won't object. :)

https://codereview.chromium.org/407543003/diff/1/crosstest/test_vector_ops.h
File crosstest/test_vector_ops.h (right):

https://codereview.chromium.org/407543003/diff/1/crosstest/test_vector_ops.h#...
crosstest/test_vector_ops.h:43: #endif
#endif // TEST_VECTOR_OPS_H

https://codereview.chromium.org/407543003/diff/20001/crosstest/vectors.h
File crosstest/vectors.h (right):

https://codereview.chromium.org/407543003/diff/20001/crosstest/vectors.h#newc...
crosstest/vectors.h:1: //===- subzero/crosstest/vectors.h - Common SIMD vector
utilies -*- C++ -*-===//
While you're touching this, could you add the license stuff to the other source
files you're modifying?

[wala, 2014-07-19 00:11:14]

https://codereview.chromium.org/407543003/diff/1/crosstest/test_arith.cpp
File crosstest/test_arith.cpp (right):

https://codereview.chromium.org/407543003/diff/1/crosstest/test_arith.cpp#new...
crosstest/test_arith.cpp:6: #include "vectors.h"
On 2014/07/18 23:45:47, stichnot wrote:
> On 2014/07/18 22:50:40, jvoung wrote:
> > Could test_arith.h just be the one to include vectors.h? Then the order
> doesn't
> > matter so much (otherwise here you need to include vectors.h before you can
> > include test_arith.h")
> 
> There's some stuff in vectors.h that you might be tempted to actually use in
the
> cross test, which would lead to link errors due to the Subzero_ prefix being
> added.  E.g. vectAsString().  So in principle, I would try to minimize the
> includes for the cross test.
> 
> With that said, if the change still links, then I won't object. :)

It links. vectors.h is mostly for the benefit of the driver and the only thing
that the crosstested code actually should use is the typedefs.

https://codereview.chromium.org/407543003/diff/20001/crosstest/vectors.h
File crosstest/vectors.h (right):

https://codereview.chromium.org/407543003/diff/20001/crosstest/vectors.h#newc...
crosstest/vectors.h:1: //===- subzero/crosstest/vectors.h - Common SIMD vector
utilies -*- C++ -*-===//
On 2014/07/18 23:45:47, stichnot wrote:
> While you're touching this, could you add the license stuff to the other
source
> files you're modifying?

Done.

[Jim Stichnoth, 2014-07-21 22:28:53]

LGTM, but please don't forget
https://codereview.chromium.org/407543003/diff/1/crosstest/test_vector_ops.h#...
(last line of file).

[wala, 2014-07-21 23:45:11]

https://codereview.chromium.org/407543003/diff/1/crosstest/test_vector_ops.h
File crosstest/test_vector_ops.h (right):

https://codereview.chromium.org/407543003/diff/1/crosstest/test_vector_ops.h#...
crosstest/test_vector_ops.h:43: #endif
On 2014/07/18 23:45:47, stichnot wrote:
> #endif // TEST_VECTOR_OPS_H

Done.

[jvoung (off chromium), 2014-07-22 16:58:34]

(LGTM too)

[wala, 2014-07-22 17:55:33]

Committed patchset #4 manually as r89a7c2b (presubmit successful).