Factor out common vector crosstesting code.

crosstest/test_arith.cpp

 // This aims to test all the arithmetic bitcode instructions across
 // all PNaCl primitive data types.
 
 #include <stdint.h>
 
+#include "vectors.h"

[jvoung (off chromium), 2014/07/18 22:50:40]

Could test_arith.h just be the one to include vectors.h? Then the order doesn't
matter so much (otherwise here you need to include vectors.h before you can
include test_arith.h")

[wala, 2014/07/18 23:08:23]

Done.

[Jim Stichnoth, 2014/07/18 23:45:47]

There's some stuff in vectors.h that you might be tempted to actually use in the
cross test, which would lead to link errors due to the Subzero_ prefix being
added.  E.g. vectAsString().  So in principle, I would try to minimize the
includes for the cross test.

With that said, if the change still links, then I won't object. :)

[wala, 2014/07/19 00:11:14]

It links. vectors.h is mostly for the benefit of the driver and the only thing
that the crosstested code actually should use is the typedefs.

 #include "test_arith.h"
 
 #define X(inst, op, isdiv)                                                     \
   bool test##inst(bool a, bool b) { return a op b; }                           \
   uint8_t test##inst(uint8_t a, uint8_t b) { return a op b; }                  \
   uint16_t test##inst(uint16_t a, uint16_t b) { return a op b; }               \
   uint32_t test##inst(uint32_t a, uint32_t b) { return a op b; }               \
   uint64_t test##inst(uint64_t a, uint64_t b) { return a op b; }               \
   v4ui32 test##inst(v4ui32 a, v4ui32 b) { return a op b; }                     \
   v8ui16 test##inst(v8ui16 a, v8ui16 b) { return a op b; }                     \
@@ skipping 12 matching lines @@
   v16si8 test##inst(v16si8 a, v16si8 b) { return a op b; }
 SINTOP_TABLE
 #undef X
 
 #define X(inst, op, func)                                                      \
   float test##inst(float a, float b) { return func(a op b); }                  \
   double test##inst(double a, double b) { return func(a op b); }               \
   v4f32 test##inst(v4f32 a, v4f32 b) { return func(a op b); }
 FPOP_TABLE
 #undef X