Show post-install UI when ephemeral apps are promoted to installed apps

chrome/browser/extensions/webstore_standalone_installer.cc

Index: chrome/browser/extensions/webstore_standalone_installer.cc
diff --git a/chrome/browser/extensions/webstore_standalone_installer.cc b/chrome/browser/extensions/webstore_standalone_installer.cc
index 9eba52f7de5edc7d77bd167f484c1d32f26e7066..51ac537ee956c7d658cf8d9d39becfa4ade05608 100644
--- a/chrome/browser/extensions/webstore_standalone_installer.cc
+++ b/chrome/browser/extensions/webstore_standalone_installer.cc
@@ -9,6 +9,7 @@
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
+#include "chrome/browser/extensions/extension_install_ui_util.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/install_tracker.h"
 #include "chrome/browser/extensions/webstore_data_fetcher.h"
@@ -360,6 +361,8 @@ void WebstoreStandaloneInstaller::InstallUIProceed() {
         // to update the extension.
         done = false;
       } else {
+        install_ui::ShowPostInstallUIForApproval(
+            profile_, *approval, installed_extension);
         extension_service->PromoteEphemeralApp(installed_extension, false);

[asargent_no_longer_on_chrome, 2014/07/21 23:23:16]

I notice that both of the places we call PromoteEphemeralApp (here, and in
webstore_private_api.cc) you needed to add the call to
ShowPostInstallUIForApproval. Would it make sense to push the call to
ShowPostInstallUIForApproval inside PromoteEphemeralApp?

[tmdiep, 2014/07/21 23:32:24]

Hmm, I'm inclined to keep the post-install UI out of ExtensionService. The
WebstorePrivateAPI and WebstoreStandaloneInstaller both are user-initiated, so
it makes sense to show the post-install UI. But we also call
PromoteEphemeralApp() from ExtensionSyncService - in this case the process
should be silent.

We'll have to duplicate the call to ShowPostInstallUIForApproval(), but I
created the util function so that most of the code doesn't have to be
duplicated.

       }
     } else if (!extension_service->IsExtensionEnabled(id_)) {