Show post-install UI when ephemeral apps are promoted to installed apps

chrome/browser/extensions/webstore_standalone_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_standalone_installer.h"
 
 #include "base/values.h"
 #include "base/version.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
+#include "chrome/browser/extensions/extension_install_ui_util.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/install_tracker.h"
 #include "chrome/browser/extensions/webstore_data_fetcher.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/extension_util.h"
 #include "extensions/common/extension.h"
@@ skipping 331 matching lines @@
                         kInvalidManifestError);
         return;
       }
 
       if (installed_extension->version()->CompareTo(
               *extension_to_install->version()) < 0) {
         // If the existing extension is out of date, proceed with the install
         // to update the extension.
         done = false;
       } else {
+        install_ui::ShowPostInstallUIForApproval(
+            profile_, *approval, installed_extension);
         extension_service->PromoteEphemeralApp(installed_extension, false);

[asargent_no_longer_on_chrome, 2014/07/21 23:23:16]

I notice that both of the places we call PromoteEphemeralApp (here, and in
webstore_private_api.cc) you needed to add the call to
ShowPostInstallUIForApproval. Would it make sense to push the call to
ShowPostInstallUIForApproval inside PromoteEphemeralApp?

[tmdiep, 2014/07/21 23:32:24]

Hmm, I'm inclined to keep the post-install UI out of ExtensionService. The
WebstorePrivateAPI and WebstoreStandaloneInstaller both are user-initiated, so
it makes sense to show the post-install UI. But we also call
PromoteEphemeralApp() from ExtensionSyncService - in this case the process
should be silent.

We'll have to duplicate the call to ShowPostInstallUIForApproval(), but I
created the util function so that most of the code doesn't have to be
duplicated.

       }
     } else if (!extension_service->IsExtensionEnabled(id_)) {
       // If the extension is installed but disabled, and not blacklisted,
       // enable it.
       extension_service->EnableExtension(id_);
     }  // else extension is installed and enabled; no work to be done.
 
     if (done) {
       CompleteInstall(install_result, install_message);
       return;
@@ skipping 57 matching lines @@
 void WebstoreStandaloneInstaller::OnWebStoreDataFetcherDone() {
   // An instance of this class is passed in as a delegate for the
   // WebstoreInstallHelper, ExtensionInstallPrompt and WebstoreInstaller, and
   // therefore needs to remain alive until they are done. Clear the webstore
   // data fetcher to avoid calling Release in AbortInstall while any of these
   // operations are in progress.
   webstore_data_fetcher_.reset();
 }
 
 }  // namespace extensions