[Mac] Update the warnings UI for malicious downloads.

[Mac] Update the warnings UI for malicious downloads.

When SafeBrowsing detects that a download is malicious, the user is only
presented with a 'Dismiss' option. Additional options ('Learn more' and
optionally 'Report', if applicable) are available from a context menu.

This behavior has been available on the Windows build. This change
brings the Mac UI up to parity.

XIB Changes (DownloadItem.xib):
* Add new controls for malicious downloads:
  * New GTMWidthBasedTweaker for managing the size of 'Dismiss' button
    connected to maliciousButtonTweaker: IBOutlet.
  * New 'Dismiss' push button connected to dismissMaliciousDownload:
    IBAction.
  * New disclosure button connected to showContextMenu: IBAction.
* Change connection for GTMWidthBasedTweaker containing 'Discard' button
  to dangerousButtonTweaker: IBOutlet.
* Anchor WidthBasedTweakers on the left instead of the right since the
  code assumes that the tweakers don't shift horizontally when the
  embedded buttons change size.
* Change height of Insecure Download NSBox to match the height of the
  DownloadItemButton.
* Adjust position of buttons for both dangerous and malicious downloads
  so that they are centered in the download shelf.

BUG=235931
TEST=(1) Download something from a URL that is identified by SafeBrowsing
         as malicious.
     (2) Check that the download shelf displays a warning indicating that
         the download was malicious and that it was blocked. There should
         only be a "Dismiss" button and a disclosure button.
     (3) Click on the disclosure button. It should display a menu with a
         'Learn more' item. Clicking on that item should open the
         SafeBrowsing help center article.
     (4) Click on the 'Dismiss' button. The warning should go away. If it
         was the only download, the shelf should also disappear.
     (5) Open chrome://downloads. The download should still be here with
         a 'Recover' option and a 'Remove' option.

[asanka, 2013-10-24 21:07:28]

Screenshot at https://code.google.com/p/chromium/issues/detail?id=235931#c5

The objective is to make the malicious download warning only allow 'Discard' as
an option on the shelf. While the UI looks and functions, the implementation is
hacky. Could you advise on a cleaner implementation?

The current code uses a DownloadItemButton to implement the drop down button for
the malicious warning and to provide a consistent background for the dangerous
download warning.

[Nico, 2013-10-24 21:50:16]

The screenshot looks like the "this is dangerous" thingy now looks like a
regular download item, suggesting that it's a button. But then it has button
children? What happens if you click on the "this is dangerous" text?

[asanka, 2013-10-24 22:24:26]

On 2013/10/24 21:50:16, Nico wrote:
> The screenshot looks like the "this is dangerous" thingy now looks like a
> regular download item, suggesting that it's a button. But then it has button
> children? What happens if you click on the "this is dangerous" text?

Clicking on the text does nothing. I see what you mean by the appearance
suggesting it's a button. Let me see if I can make it look like a NSBox.

[Nico, 2013-10-24 22:25:12]

On Thu, Oct 24, 2013 at 3:24 PM, <asanka@chromium.org> wrote:

> On 2013/10/24 21:50:16, Nico wrote:
>
>> The screenshot looks like the "this is dangerous" thingy now looks like a
>> regular download item, suggesting that it's a button. But then it has
>> button
>> children? What happens if you click on the "this is dangerous" text?
>>
>
> Clicking on the text does nothing. I see what you mean by the appearance
> suggesting it's a button. Let me see if I can make it look like a NSBox.
>

(what's wrong with the current appearance?)


>
>
https://codereview.chromium.**org/40733005/<https://codereview.chromium.org/4...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[asanka, 2013-10-24 22:34:01]

On 2013/10/24 22:25:12, Nico wrote:
> On Thu, Oct 24, 2013 at 3:24 PM, <mailto:asanka@chromium.org> wrote:
> 
> > On 2013/10/24 21:50:16, Nico wrote:
> >
> >> The screenshot looks like the "this is dangerous" thingy now looks like a
> >> regular download item, suggesting that it's a button. But then it has
> >> button
> >> children? What happens if you click on the "this is dangerous" text?
> >>
> >
> > Clicking on the text does nothing. I see what you mean by the appearance
> > suggesting it's a button. Let me see if I can make it look like a NSBox.
> >
> 
> (what's wrong with the current appearance?)

Dangerous downloads are currently displayed with an NSBox that contains the
icon, text and buttons. I was trying to add the drop down button to it, but the
border and shape didn't match up. You can see in the "before" screenshot that
the size of the NSBox doesn't quite match the download item button even though
they are both supposed to have the same frame size.

> >
>
https://codereview.chromium.**org/40733005/%3Chttps://codereview.chromium.org...>
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[asanka, 2013-10-24 23:55:39]

On 2013/10/24 22:34:01, asanka wrote:
> On 2013/10/24 22:25:12, Nico wrote:
> > On Thu, Oct 24, 2013 at 3:24 PM, <mailto:asanka@chromium.org> wrote:
> > 
> > > On 2013/10/24 21:50:16, Nico wrote:
> > >
> > >> The screenshot looks like the "this is dangerous" thingy now looks like a
> > >> regular download item, suggesting that it's a button. But then it has
> > >> button
> > >> children? What happens if you click on the "this is dangerous" text?
> > >>
> > >
> > > Clicking on the text does nothing. I see what you mean by the appearance
> > > suggesting it's a button. Let me see if I can make it look like a NSBox.

How about https://code.google.com/p/chromium/issues/detail?id=235931#c6 ?

> > (what's wrong with the current appearance?)
> 
> Dangerous downloads are currently displayed with an NSBox that contains the
> icon, text and buttons. I was trying to add the drop down button to it, but
the
> border and shape didn't match up. You can see in the "before" screenshot that
> the size of the NSBox doesn't quite match the download item button even though
> they are both supposed to have the same frame size.
> >
>
https://codereview.chromium.**org/40733005/%253Chttps://codereview.chromium.o...>
> > >
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.

[Nico, 2013-10-24 23:59:08]

That doesn't look much different from the previous screenshot. Can't you
keep the previous look and just add a disclosure area to the right?

Clicking through to the windows bug, it seems to look like a button on a
button too. Was this accepted in UI review? It looks strange.


On Thu, Oct 24, 2013 at 4:55 PM, <asanka@chromium.org> wrote:

> On 2013/10/24 22:34:01, asanka wrote:
>
>> On 2013/10/24 22:25:12, Nico wrote:
>> > On Thu, Oct 24, 2013 at 3:24 PM, <mailto:asanka@chromium.org> wrote:
>> >
>> > > On 2013/10/24 21:50:16, Nico wrote:
>> > >
>> > >> The screenshot looks like the "this is dangerous" thingy now looks
>> like a
>> > >> regular download item, suggesting that it's a button. But then it has
>> > >> button
>> > >> children? What happens if you click on the "this is dangerous" text?
>> > >>
>> > >
>> > > Clicking on the text does nothing. I see what you mean by the
>> appearance
>> > > suggesting it's a button. Let me see if I can make it look like a
>> NSBox.
>>
>
> How about https://code.google.com/p/**chromium/issues/detail?id=**
> 235931#c6 <https://code.google.com/p/chromium/issues/detail?id=235931#c6>?
>
>
>  > (what's wrong with the current appearance?)
>>
>
>  Dangerous downloads are currently displayed with an NSBox that contains
>> the
>> icon, text and buttons. I was trying to add the drop down button to it,
>> but
>>
> the
>
>> border and shape didn't match up. You can see in the "before" screenshot
>> that
>> the size of the NSBox doesn't quite match the download item button even
>> though
>> they are both supposed to have the same frame size.
>> >
>>
>
> https://codereview.chromium.****org/40733005/%253Chttps://code**
> review.chromium.org/40733005/ <http://codereview.chromium.org/40733005/>>
>
>  > >
>> >
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an
>> email
>> > to
mailto:chromium-reviews+**unsubscribe@chromium.org<chromium-reviews%2Bunsubscribe@chromium.org>
>> .
>>
>
>
>
https://codereview.chromium.**org/40733005/<https://codereview.chromium.org/4...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[asanka, 2013-10-25 00:07:25]

On 2013/10/24 23:59:08, Nico wrote:
> That doesn't look much different from the previous screenshot. Can't you
> keep the previous look and just add a disclosure area to the right?
> 
> Clicking through to the windows bug, it seems to look like a button on a
> button too. Was this accepted in UI review? It looks strange.

Yup. It was accepted in UI review for Windows. On Windows, addition of the drop
down didn't change the appearance of the rest of the download item. Dangerous
downloads looked like what's shown in
https://code.google.com/p/chromium/issues/detail?id=102540#c30 before the
change, and like https://code.google.com/p/chromium/issues/detail?id=102540#c57
afterwards.

I'll work on adding a disclosure area instead for Mac.

> On Thu, Oct 24, 2013 at 4:55 PM, <mailto:asanka@chromium.org> wrote:
> 
> > On 2013/10/24 22:34:01, asanka wrote:
> >
> >> On 2013/10/24 22:25:12, Nico wrote:
> >> > On Thu, Oct 24, 2013 at 3:24 PM, <mailto:asanka@chromium.org> wrote:
> >> >
> >> > > On 2013/10/24 21:50:16, Nico wrote:
> >> > >
> >> > >> The screenshot looks like the "this is dangerous" thingy now looks
> >> like a
> >> > >> regular download item, suggesting that it's a button. But then it has
> >> > >> button
> >> > >> children? What happens if you click on the "this is dangerous" text?
> >> > >>
> >> > >
> >> > > Clicking on the text does nothing. I see what you mean by the
> >> appearance
> >> > > suggesting it's a button. Let me see if I can make it look like a
> >> NSBox.
> >>
> >
> > How about https://code.google.com/p/**chromium/issues/detail?id=**
> > 235931#c6 <https://code.google.com/p/chromium/issues/detail?id=235931#c6%3E?
> >
> >
> >  > (what's wrong with the current appearance?)
> >>
> >
> >  Dangerous downloads are currently displayed with an NSBox that contains
> >> the
> >> icon, text and buttons. I was trying to add the drop down button to it,
> >> but
> >>
> > the
> >
> >> border and shape didn't match up. You can see in the "before" screenshot
> >> that
> >> the size of the NSBox doesn't quite match the download item button even
> >> though
> >> they are both supposed to have the same frame size.
> >> >
> >>
> >
> > https://codereview.chromium.****org/40733005/%25253Chttps://code**
> > review.chromium.org/40733005/ <http://codereview.chromium.org/40733005/>>
> >
> >  > >
> >> >
> >> > To unsubscribe from this group and stop receiving emails from it, send
> >> an
> >> email
> >> > to
>
mailto:chromium-reviews+**unsubscribe@chromium.org<chromium-reviews%2Bunsubscribe@chromium.org>
> >> .
> >>
> >
> >
> >
>
https://codereview.chromium.**org/40733005/%3Chttps://codereview.chromium.org...>
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[asanka, 2013-10-25 16:35:27]

On 2013/10/25 00:07:25, asanka wrote:
> On 2013/10/24 23:59:08, Nico wrote:
> > That doesn't look much different from the previous screenshot. Can't you
> > keep the previous look and just add a disclosure area to the right?
> > 
> > Clicking through to the windows bug, it seems to look like a button on a
> > button too. Was this accepted in UI review? It looks strange.
> 
> Yup. It was accepted in UI review for Windows. On Windows, addition of the
drop
> down didn't change the appearance of the rest of the download item. Dangerous
> downloads looked like what's shown in
> https://code.google.com/p/chromium/issues/detail?id=102540#c30 before the
> change, and like
https://code.google.com/p/chromium/issues/detail?id=102540#c57
> afterwards.
> 
> I'll work on adding a disclosure area instead for Mac.

https://code.google.com/p/chromium/issues/detail?id=235931#c9 ?

> > On Thu, Oct 24, 2013 at 4:55 PM, <mailto:asanka@chromium.org> wrote:
> > 
> > > On 2013/10/24 22:34:01, asanka wrote:
> > >
> > >> On 2013/10/24 22:25:12, Nico wrote:
> > >> > On Thu, Oct 24, 2013 at 3:24 PM, <mailto:asanka@chromium.org> wrote:
> > >> >
> > >> > > On 2013/10/24 21:50:16, Nico wrote:
> > >> > >
> > >> > >> The screenshot looks like the "this is dangerous" thingy now looks
> > >> like a
> > >> > >> regular download item, suggesting that it's a button. But then it
has
> > >> > >> button
> > >> > >> children? What happens if you click on the "this is dangerous" text?
> > >> > >>
> > >> > >
> > >> > > Clicking on the text does nothing. I see what you mean by the
> > >> appearance
> > >> > > suggesting it's a button. Let me see if I can make it look like a
> > >> NSBox.
> > >>
> > >
> > > How about https://code.google.com/p/**chromium/issues/detail?id=**
> > > 235931#c6
<https://code.google.com/p/chromium/issues/detail?id=235931#c6%253E?
> > >
> > >
> > >  > (what's wrong with the current appearance?)
> > >>
> > >
> > >  Dangerous downloads are currently displayed with an NSBox that contains
> > >> the
> > >> icon, text and buttons. I was trying to add the drop down button to it,
> > >> but
> > >>
> > > the
> > >
> > >> border and shape didn't match up. You can see in the "before" screenshot
> > >> that
> > >> the size of the NSBox doesn't quite match the download item button even
> > >> though
> > >> they are both supposed to have the same frame size.
> > >> >
> > >>
> > >
> > > https://codereview.chromium.****org/40733005/%2525253Chttps://code**
> > > review.chromium.org/40733005/ <http://codereview.chromium.org/40733005/>>
> > >
> > >  > >
> > >> >
> > >> > To unsubscribe from this group and stop receiving emails from it, send
> > >> an
> > >> email
> > >> > to
> >
>
mailto:chromium-reviews+**unsubscribe@chromium.org<chromium-reviews%2Bunsubscribe@chromium.org>
> > >> .
> > >>
> > >
> > >
> > >
> >
>
https://codereview.chromium.**org/40733005/%253Chttps://codereview.chromium.o...>
> > >
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.

[asanka, 2013-10-25 19:22:36]

On 2013/10/25 16:35:27, asanka wrote:
> On 2013/10/25 00:07:25, asanka wrote:
> > On 2013/10/24 23:59:08, Nico wrote:
> > > That doesn't look much different from the previous screenshot. Can't you
> > > keep the previous look and just add a disclosure area to the right?
> > > 
> > > Clicking through to the windows bug, it seems to look like a button on a
> > > button too. Was this accepted in UI review? It looks strange.
> > 
> > Yup. It was accepted in UI review for Windows. On Windows, addition of the
> drop
> > down didn't change the appearance of the rest of the download item.
Dangerous
> > downloads looked like what's shown in
> > https://code.google.com/p/chromium/issues/detail?id=102540#c30 before the
> > change, and like
> https://code.google.com/p/chromium/issues/detail?id=102540#c57
> > afterwards.
> > 
> > I'll work on adding a disclosure area instead for Mac.
> 
> https://code.google.com/p/chromium/issues/detail?id=235931#c9 ?

https://code.google.com/p/chromium/issues/detail?id=235931#c10

Also updated patchset.

> 
> > > On Thu, Oct 24, 2013 at 4:55 PM, <mailto:asanka@chromium.org> wrote:
> > > 
> > > > On 2013/10/24 22:34:01, asanka wrote:
> > > >
> > > >> On 2013/10/24 22:25:12, Nico wrote:
> > > >> > On Thu, Oct 24, 2013 at 3:24 PM, <mailto:asanka@chromium.org> wrote:
> > > >> >
> > > >> > > On 2013/10/24 21:50:16, Nico wrote:
> > > >> > >
> > > >> > >> The screenshot looks like the "this is dangerous" thingy now looks
> > > >> like a
> > > >> > >> regular download item, suggesting that it's a button. But then it
> has
> > > >> > >> button
> > > >> > >> children? What happens if you click on the "this is dangerous"
text?
> > > >> > >>
> > > >> > >
> > > >> > > Clicking on the text does nothing. I see what you mean by the
> > > >> appearance
> > > >> > > suggesting it's a button. Let me see if I can make it look like a
> > > >> NSBox.
> > > >>
> > > >
> > > > How about https://code.google.com/p/**chromium/issues/detail?id=**
> > > > 235931#c6
> <https://code.google.com/p/chromium/issues/detail?id=235931#c6%25253E?
> > > >
> > > >
> > > >  > (what's wrong with the current appearance?)
> > > >>
> > > >
> > > >  Dangerous downloads are currently displayed with an NSBox that contains
> > > >> the
> > > >> icon, text and buttons. I was trying to add the drop down button to it,
> > > >> but
> > > >>
> > > > the
> > > >
> > > >> border and shape didn't match up. You can see in the "before"
screenshot
> > > >> that
> > > >> the size of the NSBox doesn't quite match the download item button even
> > > >> though
> > > >> they are both supposed to have the same frame size.
> > > >> >
> > > >>
> > > >
> > > > https://codereview.chromium.****org/40733005/%252525253Chttps://code**
> > > > review.chromium.org/40733005/
<http://codereview.chromium.org/40733005/>>
> > > >
> > > >  > >
> > > >> >
> > > >> > To unsubscribe from this group and stop receiving emails from it,
send
> > > >> an
> > > >> email
> > > >> > to
> > >
> >
>
mailto:chromium-reviews+**unsubscribe@chromium.org<chromium-reviews%2Bunsubscribe@chromium.org>
> > > >> .
> > > >>
> > > >
> > > >
> > > >
> > >
> >
>
https://codereview.chromium.**org/40733005/%25253Chttps://codereview.chromium...>
> > > >
> > > 
> > > To unsubscribe from this group and stop receiving emails from it, send an
> > email
> > > to mailto:chromium-reviews+unsubscribe@chromium.org.

[asanka, 2013-10-29 20:51:25]

ping?

[asanka, 2013-11-01 21:31:37]

On 2013/10/29 20:51:25, asanka wrote:
> ping?

thakis: ping again?

[Nico, 2013-11-02 00:13:51]

lgtm

I like this much better. Sorry for the delay!

https://codereview.chromium.org/40733005/diff/170001/chrome/app/nibs/Download...
File chrome/app/nibs/DownloadItem.xib (right):

https://codereview.chromium.org/40733005/diff/170001/chrome/app/nibs/Download...
chrome/app/nibs/DownloadItem.xib:1: <?xml version="1.0" encoding="UTF-8"?>
In the CL description, typo "WidthBasedTwekers"

Mention that the dismiss button is hooked up to the new ibaction method

https://codereview.chromium.org/40733005/diff/170001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/download/download_item_controller.mm (right):

https://codereview.chromium.org/40733005/diff/170001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/download/download_item_controller.mm:341: forView:[self
view]];
Does "forView:sender" make a visual difference? If not, this is fine.

[Nico, 2013-11-02 00:14:07]

lgtm

I like this much better. Sorry for the delay!

[asanka, 2013-11-02 05:41:36]

Thanks!

https://codereview.chromium.org/40733005/diff/170001/chrome/app/nibs/Download...
File chrome/app/nibs/DownloadItem.xib (right):

https://codereview.chromium.org/40733005/diff/170001/chrome/app/nibs/Download...
chrome/app/nibs/DownloadItem.xib:1: <?xml version="1.0" encoding="UTF-8"?>
On 2013/11/02 00:13:51, Nico wrote:
> In the CL description, typo "WidthBasedTwekers"

Haha. Fixed.

> Mention that the dismiss button is hooked up to the new ibaction method

Done.

https://codereview.chromium.org/40733005/diff/170001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/download/download_item_controller.mm (right):

https://codereview.chromium.org/40733005/diff/170001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/download/download_item_controller.mm:341: forView:[self
view]];
On 2013/11/02 00:13:51, Nico wrote:
> Does "forView:sender" make a visual difference? If not, this is fine.

The behavior with "[self view]" appeared correct. But I'll try it with "sender"
and see if there's a difference.

[asanka, 2013-11-04 16:53:46]

https://codereview.chromium.org/40733005/diff/170001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/download/download_item_controller.mm (right):

https://codereview.chromium.org/40733005/diff/170001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/download/download_item_controller.mm:341: forView:[self
view]];
On 2013/11/02 05:41:36, asanka wrote:
> On 2013/11/02 00:13:51, Nico wrote:
> > Does "forView:sender" make a visual difference? If not, this is fine.
> 
> The behavior with "[self view]" appeared correct. But I'll try it with
"sender"
> and see if there's a difference.

Tried both ways, and there was no difference.

[asanka, 2013-11-04 22:04:23]

Closed due to busted Base URL and moved to
https://codereview.chromium.org/57963005/.