Source/core/rendering/InlineFlowBox.cpp - Issue 40733004: Replace compile flag with runtime check for text-underline-position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineFlowBox.cpp

Issue 40733004: Replace compile flag with runtime check for text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed a typo in static function compileUnderlineOffset signature / Rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/InlineFlowBox.cpp

diff --git a/Source/core/rendering/InlineFlowBox.cpp b/Source/core/rendering/InlineFlowBox.cpp

index f33c69ee0755ba27945102b79d5bcf662260f0d7..3c55684cd1ce1ca2e01aff5b56566036f525eec6 100644

--- a/Source/core/rendering/InlineFlowBox.cpp

+++ b/Source/core/rendering/InlineFlowBox.cpp

@@ -728,7 +728,6 @@ void InlineFlowBox::placeBoxesInBlockDirection(LayoutUnit top, LayoutUnit maxHei

}

-#if ENABLE(CSS3_TEXT)

void InlineFlowBox::computeMaxLogicalTop(float& maxLogicalTop) const

{

for (InlineBox* curr = firstChild(); curr; curr = curr->nextOnLine()) {

@@ -745,7 +744,6 @@ void InlineFlowBox::computeMaxLogicalTop(float& maxLogicalTop) const

maxLogicalTop = max<float>(maxLogicalTop, localMaxLogicalTop);

}

-#endif // CSS3_TEXT

void InlineFlowBox::flipLinesInBlockDirection(LayoutUnit lineTop, LayoutUnit lineBottom)

{