Source/core/css/CSSPropertyNames.in - Issue 40733004: Replace compile flag with runtime check for text-underline-position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPropertyNames.in

Issue 40733004: Replace compile flag with runtime check for text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed a typo in static function compileUnderlineOffset signature / Rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSPropertyNames.in

diff --git a/Source/core/css/CSSPropertyNames.in b/Source/core/css/CSSPropertyNames.in

index cf8436e82dea34cb2538bacddf4e85b0dba3a48c..f5a08fe56f03d3295b56d3ceecc91707ca8ca63e 100644

--- a/Source/core/css/CSSPropertyNames.in

+++ b/Source/core/css/CSSPropertyNames.in

@@ -212,6 +212,7 @@ text-underline-color

text-underline-mode

text-underline-style

text-underline-width

+text-underline-position

top

touch-action

touch-action-delay

@@ -382,7 +383,6 @@ order

-webkit-ruby-position

-webkit-text-combine

-epub-text-combine alias_for=-webkit-text-combine

--webkit-text-underline-position condition=CSS3_TEXT

Julien - ping for review 2013/10/31 22:54:07 Same comment here about a "conditional" follow-up.

abinader 2013/11/01 12:16:42 Ack!

-webkit-text-decorations-in-effect

-webkit-text-emphasis

-epub-text-emphasis alias_for=-webkit-text-emphasis