Source/core/css/CSSProperties.in - Issue 40733004: Replace compile flag with runtime check for text-underline-position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSProperties.in

Issue 40733004: Replace compile flag with runtime check for text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed a typo in static function compileUnderlineOffset signature / Rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSProperties.in

diff --git a/Source/core/css/CSSProperties.in b/Source/core/css/CSSProperties.in

index f6eb0ee008ba0d96e1d916d6db47185027c40d0e..f71cf63ff7ac5eeb6ba17ae79cc8e8612e820b57 100644

--- a/Source/core/css/CSSProperties.in

+++ b/Source/core/css/CSSProperties.in

@@ -239,7 +239,7 @@ column-fill type_name=ColumnFill

-webkit-text-fill-color custom_all

-webkit-text-security

-webkit-text-stroke-color custom_all

--webkit-text-underline-position custom_value, condition=CSS3_TEXT

Julien - ping for review 2013/10/31 22:54:07 This was the last property with "condition", we ma

abinader 2013/11/01 12:16:42 Yes :-D I am going to remove that on a separate pa

+text-underline-position custom_value

-webkit-transform-origin-x type_name=Length, converter=convertLength

-webkit-transform-origin-y type_name=Length, converter=convertLength

-webkit-transform-origin-z type_name=float, converter=convertComputedLength<float>