Issue 40733002: Devirtualize SerializedScriptValue's destructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40733002: Devirtualize SerializedScriptValue's destructor (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
haraken, abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Devirtualize SerializedScriptValue's destructor Devirtualize SerializedScriptValue's destructor to avoid creating an unnecessary vtable. SerializedScriptValue is never subclassed nor does it have any virtual function. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160477

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/bindings/v8/SerializedScriptValue.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/40733002/1

7 years, 2 months ago (2013-10-24 17:14:02 UTC) #3

commit-bot: I haz the power

Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=9738

7 years, 2 months ago (2013-10-24 17:27:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/40733002/1

7 years, 2 months ago (2013-10-24 17:35:25 UTC) #5

Message was sent while issue was closed.

Change committed as 160477

Expand Messages | Collapse Messages