Source/bindings/v8/SerializedScriptValue.h - Issue 40733002: Devirtualize SerializedScriptValue's destructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/SerializedScriptValue.h

Issue 40733002: Devirtualize SerializedScriptValue's destructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/SerializedScriptValue.h

diff --git a/Source/bindings/v8/SerializedScriptValue.h b/Source/bindings/v8/SerializedScriptValue.h

index 2d94ec9edd50eaf4faf0652c0d4c6537f38c45bd..a785365dd56eda4520a94c2ef1d0505076269c2d 100644

--- a/Source/bindings/v8/SerializedScriptValue.h

+++ b/Source/bindings/v8/SerializedScriptValue.h

@@ -60,7 +60,7 @@ public:

// Version 3: Switched to using uuids as blob data identifiers.

static const uint32_t wireFormatVersion = 3;

- virtual ~SerializedScriptValue();

+ ~SerializedScriptValue();

// If a serialization error occurs (e.g., cyclic input value) this

// function returns an empty representation, schedules a V8 exception to

« no previous file with comments | « no previous file | no next file » | no next file with comments »