Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 407183003: add portable and canonical font support for DM (Closed)

Created:
6 years, 5 months ago by caryclark
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add standard fonts to all GMs. Allow GM results to be compared across machines and platforms by standardizing the fonts used by all tests. This adds runtime flags to DM to use either the system font context (the default), the fonts in the resources directory ( --resourceFonts ) or a set of canonical paths generated from the fonts ( --portableFonts ). This CL should leave the current DM results unchanged by default. If the portable font data or resource font is missing when DM is run, it falls back to using the system font context. The create_test_font tool generates the paths and metrics read by DM with the --portableFonts flag set, and generates the font substitution tables read by DM with the --resourceFonts flag set. If DM is run in SkDebug mode with the --reportUsedChars flag set, it generates the corresponding data compiled into the create_test_font tool. All GM tests set their typeface information by calling either sk_tool_utils::set_portable_typeface or sk_tool_utils::portable_typeface . (The former takes the paint, the latter returns a SkTypeface.) These calls can be removed in the future when the Font Manager can be superceded. BUG=skia:2687 R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/992c7b0

Patch Set 1 #

Patch Set 2 : generate table of chars per font used by gm #

Patch Set 3 : standardize constructed paths #

Patch Set 4 : fix linux-exposed bugs #

Total comments: 15

Patch Set 5 : add atexit; rename to create_... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9616 lines, -3144 lines) Patch
M dm/DM.cpp View 1 2 3 4 3 chunks +10 lines, -1 line 0 comments Download
M gm/bigtext.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/colortype.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M gm/convexpolyclip.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/cubicpaths.cpp View 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M gm/deviceproperties.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gm/downsamplebitmap.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gm/drawbitmaprect.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/drawlooper.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/dropshadowimagefilter.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/emptypath.cpp View 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M gm/filterbitmap.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gm/fontcache.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M gm/fontscaler.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gm/gammatext.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gm/getpostextpath.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/glyph_pos.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gm/gradtext.cpp View 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M gm/image.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/imageblur.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/imageblurtiled.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/imagefiltersbase.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/imagefilterscropped.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/imagemagnifier.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/imageresizetiled.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/internal_links.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/lcdtext.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/lighting.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/linepaths.cpp View 2 3 4 4 chunks +4 lines, -0 lines 0 comments Download
M gm/lumafilter.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/matrixconvolution.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/morphology.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/offsetimagefilter.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/pathreverse.cpp View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M gm/pictureimagefilter.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/poly2poly.cpp View 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M gm/quadpaths.cpp View 2 3 4 4 chunks +4 lines, -0 lines 0 comments Download
M gm/samplerstress.cpp View 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M gm/shadertext.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/shadertext2.cpp View 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M gm/shadertext3.cpp View 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M gm/simpleaaclip.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/srcmode.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/strokefill.cpp View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M gm/stroketext.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/texteffects.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/tileimagefilter.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/tilemodes.cpp View 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M gm/twopointradial.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/typeface.cpp View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M gm/variedtext.cpp View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M gm/verttext2.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/xfermodes.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/xfermodes2.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gm/xfermodes3.cpp View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tools.gyp View 1 2 3 4 4 chunks +25 lines, -15 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M src/fonts/SkTestScalerContext.h View 1 2 3 4 1 chunk +95 lines, -3 lines 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 2 3 4 3 chunks +147 lines, -103 lines 0 comments Download
M tools/create_test_font.cpp View 1 2 3 4 2 chunks +385 lines, -104 lines 0 comments Download
M tools/sk_tool_utils.h View 1 2 3 4 2 chunks +13 lines, -6 lines 0 comments Download
M tools/sk_tool_utils.cpp View 1 2 3 4 2 chunks +19 lines, -8 lines 0 comments Download
A tools/sk_tool_utils_flags.h View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M tools/sk_tool_utils_font.cpp View 1 2 3 4 1 chunk +159 lines, -2873 lines 0 comments Download
A tools/test_font_data.cpp View 1 2 3 4 1 chunk +8622 lines, -0 lines 0 comments Download
A tools/test_font_data_chars.cpp View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
caryclark
6 years, 5 months ago (2014-07-22 20:21:55 UTC) #1
caryclark
since Sunshine is back, add him to the review
6 years, 4 months ago (2014-07-29 20:50:29 UTC) #2
mtklein
https://codereview.chromium.org/407183003/diff/40001/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/407183003/diff/40001/dm/DM.cpp#newcode53 dm/DM.cpp:53: DEFINE_bool(reportUsedChars, false, "Output test font construction data to be ...
6 years, 4 months ago (2014-07-30 15:03:58 UTC) #3
caryclark
https://codereview.chromium.org/407183003/diff/40001/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/407183003/diff/40001/dm/DM.cpp#newcode53 dm/DM.cpp:53: DEFINE_bool(reportUsedChars, false, "Output test font construction data to be ...
6 years, 4 months ago (2014-07-30 15:45:33 UTC) #4
mtklein
https://codereview.chromium.org/407183003/diff/40001/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/407183003/diff/40001/dm/DM.cpp#newcode243 dm/DM.cpp:243: sk_tool_utils::release_portable_typeface(); On 2014/07/30 15:45:32, caryclark wrote: > On 2014/07/30 ...
6 years, 4 months ago (2014-07-30 17:19:05 UTC) #5
caryclark
https://codereview.chromium.org/407183003/diff/40001/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/407183003/diff/40001/dm/DM.cpp#newcode243 dm/DM.cpp:243: sk_tool_utils::release_portable_typeface(); On 2014/07/30 17:19:05, mtklein wrote: > On 2014/07/30 ...
6 years, 4 months ago (2014-07-30 19:00:16 UTC) #6
mtklein
lgtm
6 years, 4 months ago (2014-07-30 19:28:42 UTC) #7
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 4 months ago (2014-07-31 12:01:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/407183003/50001
6 years, 4 months ago (2014-07-31 12:02:53 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-07-31 12:06:00 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 12:07:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/953) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/751) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot ...
6 years, 4 months ago (2014-07-31 12:07:25 UTC) #12
caryclark
6 years, 4 months ago (2014-07-31 12:58:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 manually as r992c7b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698