add portable and canonical font support for DM

dm/DM.cpp

 // Main binary for DM.
 // For a high-level overview, please see dm/README.
 
 #include "CrashHandler.h"
 #include "SkCommonFlags.h"
 #include "SkForceLinking.h"
 #include "SkGraphics.h"
 #include "SkPicture.h"
 #include "SkString.h"
 #include "Test.h"
 #include "gm.h"
+#include "sk_tool_utils.h"
+#include "sk_tool_utils_flags.h"
 
 #include "DMCpuGMTask.h"
 #include "DMGpuGMTask.h"
 #include "DMGpuSupport.h"
 #include "DMPDFTask.h"
 #include "DMReporter.h"
 #include "DMSKPTask.h"
 #include "DMTask.h"
 #include "DMTaskRunner.h"
 #include "DMTestTask.h"
@@ skipping 19 matching lines @@
 DEFINE_int32(gpuThreads, 1, "Threads for GPU work.");
 DEFINE_string2(expectations, r, "",
                "If a directory, compare generated images against images under this path. "
                "If a file, compare generated images against JSON expectations at this path."
 );
 
 DEFINE_string(skps, "", "Directory to read skps from.");
 
 DEFINE_bool(gms, true, "Run GMs?");
 DEFINE_bool(tests, true, "Run tests?");
+DEFINE_bool(reportUsedChars, false, "Output test font construction data to be pasted into"

[mtklein, 2014/07/30 15:03:57]

Is it silly to just preemptively create paths for all characters we're likely to
type?

[caryclark, 2014/07/30 15:45:32]

My first pass was to do just that, and that may make the most sense once the GMs
are tightened up. 

My constraint for this CL is to leave the GMs alone -- I didn't want to confuse
this CL with rebaselining that might be caused by mistakes versus intentional
changes to make GMs better. So that required that I support all of the fonts and
chars that the current GMs use.

Enlarging these font ranges to create paths for all ASCII ballooned up the file
that creates the paths to over 1M, which means it can no longer be uploaded and
try-botted. For now, I'd rather have a just-large enough file that at least can
be part of this CL.

+                                    " create_test_font.cpp.");
 
 __SK_FORCE_IMAGE_DECODER_LINKING;
 
 // "FooBar" -> "foobar".  Obviously, ASCII only.
 static SkString lowercase(SkString s) {
     for (size_t i = 0; i < s.size(); i++) {
         s[i] = tolower(s[i]);
     }
     return s;
 }
@@ skipping 163 matching lines @@
     SkDebugf("%d GMs x %d configs, %d tests\n",
              gms.count(), configs.count(), tests.count());
     DM::Reporter reporter;
     DM::TaskRunner tasks(FLAGS_threads, FLAGS_gpuThreads);
     kick_off_gms(gms, configs, gpuAPI, *expectations, &reporter, &tasks);
     kick_off_tests(tests, &reporter, &tasks);
     kick_off_skps(&reporter, &tasks);
     tasks.wait();
 
     SkDebugf("\n");
-
+#ifdef SK_DEBUG

[mtklein, 2014/07/30 15:03:57]

Seems like you can drop the #ifdef/#endif wrapping?

[caryclark, 2014/07/30 15:45:32]

The report_used_chars relies on data gathered only in SK_DEBUG. So, while I
could drop the wrapping here, it would mislead the reader possibly to believe
that it is possible to report used chars in Release.

+    if (FLAGS_portableFonts && FLAGS_reportUsedChars) {
+        sk_tool_utils::report_used_chars();
+    }
+#endif
+    sk_tool_utils::release_portable_typeface();

[mtklein, 2014/07/30 15:03:57]

Is there a corresponding ref/acquire?  How do we know when we need to call this?
 Can it become part of SkGraphics?

[caryclark, 2014/07/30 15:45:32]

I don't doubt this could be better. Would this be more clear?

if (FLAGS_portableFonts) {
    sk_tools_utils::release_portable_typeface();
}

The ref/acquire happens in sk_tool_utils_font.cpp, in create_font(). I'd prefer
not to put this in SkGraphics but to leave this as a tool that is outside the
src/core world.

[mtklein, 2014/07/30 17:19:05]

Think we could have the portable font code register release_portable_typeface()
to be called with atexit the first time we create one?  Just seems tricky to
have to know here that somewhere inside code called by DM we we may have created
one.  Am I thinking right that GM could be using these too if you turn on the
flags, but there's no way for it to clean them up?

Maybe tack on an "s" to "typeface" too?

[caryclark, 2014/07/30 19:00:16]

Done.

[caryclark, 2014/07/30 19:00:16]

Done.

+    
     SkTArray<SkString> failures;
     reporter.getFailures(&failures);
     report_failures(failures);
     return failures.count() > 0;
 }
 
 #if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL)
 int main(int argc, char** argv) {
     SkCommandLineFlags::Parse(argc, argv);
     return dm_main();
 }
 #endif